Skip to content

Add options to dump_course_structure to output inherited metadata. - #2008

Merged
brianhw merged 2 commits into
masterfrom
brian/dump-inherited-metadata
Jan 3, 2014
Merged

Add options to dump_course_structure to output inherited metadata.#2008
brianhw merged 2 commits into
masterfrom
brian/dump-inherited-metadata

Conversation

@brianhw

@brianhw brianhw commented Dec 19, 2013

Copy link
Copy Markdown
Contributor

@rocha @mulby This optionally adds additional metadata to the course-structure dumps, for the convenience of researchers.

@rocha

rocha commented Dec 20, 2013

Copy link
Copy Markdown
Contributor

@brianhw tests for this command are in lms/djangoapps/courseware/tests/test_commands.py. It may be a good idea to add some tests for the inherited metadata.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do this inside dump_module?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a one-time call -- it should be called only once for the entire course. dump_module is called recursively.

@mulby

mulby commented Jan 3, 2014

Copy link
Copy Markdown
Contributor

LGTM 🚀

brianhw added a commit that referenced this pull request Jan 3, 2014
Add options to dump_course_structure to output inherited metadata.
@brianhw
brianhw merged commit 5dccff5 into master Jan 3, 2014
@brianhw
brianhw deleted the brian/dump-inherited-metadata branch January 3, 2014 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants