Annotation tools - #2024
Closed
danielcebrian wants to merge 6 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
All of these scripts need to be loaded via require.js, instead of via <script> tags.
Contributor
Author
There was a problem hiding this comment.
First of all, happy new year 2014
Thank you very much for reviewing the code
I going to answer all your reviews.
I do not know how to use Require.js. As soon as possible I will try to use this library, and make a new pull
Contributor
|
This pull request is going to need a lot of cleanup before it's ready to go in: probably some major refactoring to account for things like internationalization, modular, testable Javascript, RESTful URL routing, and so on. I also don't see any tests whatsoever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the first round of annotation tools for the platform. Included are Text and Video annotation modules along with the My Notes page module that aggregates all annotations.