Tests for behavior of export with & in HTML and XML-based components - #2055
Merged
Conversation
added 2 commits
December 30, 2013 15:08
Part of STUD-91
Part of STUD-91
Contributor
There was a problem hiding this comment.
We should not be using a pattern of absorbing all the methods from component_settings_editor_helpers into world. Instead we should just import them. Can you please refactor this?
Author
|
@jzoldak Can I get a thumb? |
Contributor
|
👍 |
cahrens
pushed a commit
that referenced
this pull request
Jan 7, 2014
Tests for behavior of export with & in HTML and XML-based components
shimulch
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 26, 2021
Releasing `v3.2.2`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are tests to nail down the current behavior of export with & exists in an HTML component or a problem (XML) component.
See STUD-91
& is OK in an HTML component, and there is an import/export roundtrip test that uses the toy course. Therefore I added & to an existing HTML component in the toy course.
& is not OK in a problem (XML-based component). I added a test that export will fail with a way to click to the failing component. The Studio preview view of the component shows the error, so this failure should be clear to users.
@jzoldak Please review.