Skip to content

Assign valid content_type to static resource (import_static_content) - #2075

Merged
zubair-arbi merged 1 commit into
openedx:masterfrom
zubair-arbi:zub/bugfix/std878-wrongcontenttype
Jan 7, 2014
Merged

Assign valid content_type to static resource (import_static_content)#2075
zubair-arbi merged 1 commit into
openedx:masterfrom
zubair-arbi:zub/bugfix/std878-wrongcontenttype

Conversation

@zubair-arbi

Copy link
Copy Markdown
Contributor

STUD-878

@singingwolfboy @cahrens @adampalay

While importing static_content of a course check if provided 'contentType' in asset.json is valid, otherwise assign guessed mime type. I updated dummy course "Toy" for testing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get already defaults to None

@singingwolfboy

Copy link
Copy Markdown
Contributor

Tests and everything! Awesome! 👍

@cahrens

cahrens commented Jan 6, 2014

Copy link
Copy Markdown

👍

@adampalay

Copy link
Copy Markdown
Contributor

lgtm!

zubair-arbi added a commit that referenced this pull request Jan 7, 2014
…enttype

Assign valid content_type to static resource (import_static_content)
@zubair-arbi
zubair-arbi merged commit f71688c into openedx:master Jan 7, 2014
shimulch pushed a commit to open-craft/openedx-platform that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants