Add sorting to Studio's Files & Uploads page - #2086
Conversation
There was a problem hiding this comment.
Doesn't this mean the sort direction will default to ascending if not specified? And don't we want a default of descending?
|
@frrrances Could you give this a quick check too, please. Also, did you see Christina's comment about adding a file when sorting such that the file isn't visible. She suggested always reverting the sort to most recently added when adding a file so that the new file will be at the top. Does that sound reasonable to you? |
|
👍 After clarifying the default value in assets.py and changing the behavior of adding a file (when non-default sort is selected). |
|
@cahrens Thanks for catching those issues. Frances agreed with the idea of changing back to the default sort when adding a new item, so I've implemented that and added unit tests. I've also fixed the default value handling, and submitted a ticket to have 'defaultname' be indexed. I'll wait to squash the commits until the changes are approved. |
|
@frrrances Thanks for the additional styling. Looks good to me. |
|
Here's what I hope to be the final squashed commit. Also, at @frrrances request I've added 'ascending'/'descending' to the name of the sort order. @cahrens @singingwolfboy Please re-review. |
There was a problem hiding this comment.
You don't need to modify the AUTHORS file -- doing so will just result in conflicts for other pull requests.
There was a problem hiding this comment.
That was an accidental merge conflict (I added myself as an author once with a new line and once without it). I've backed out this change.
|
@cahrens @singingwolfboy addressed DB's issues. |
|
👍 once the tests pass. |
|
@talbs can you review as well since I worked on this feature? |
|
@andy-armstrong Need to rebase. |
|
@cahrens Rebased again :-) |
|
👍 |
Added sorting to the new pagination logic for STUD-995.
|
Everything looks good from a UX and Front End Perspective. Nice work! 👍 |
Add sorting to Studio's Files & Uploads page
5 participants
Added sorting to the new pagination logic for STUD-995.
This is a rebased version of my original pull request: https://github.com/edx/edx-platform/pull/2066.
@cahrens @singingwolfboy Could you re-review please.