Skip to content

Restrict grading endpoints in LMS - #21050

Merged
uzairr merged 1 commit into
masterfrom
LEARNER-3761/capa-grading-exception
Jul 25, 2019
Merged

Restrict grading endpoints in LMS#21050
uzairr merged 1 commit into
masterfrom
LEARNER-3761/capa-grading-exception

Conversation

@uzairr

@uzairr uzairr commented Jul 10, 2019

Copy link
Copy Markdown
Contributor

LEARNER-3761

Description

Currently, grading endpoints in capa-module are vulnerable as they are not restricted.To avoid it, changes have been made so that they are available only for logged-in users.

@uzairr
uzairr requested a review from a team as a code owner July 10, 2019 17:35
@uzairr
uzairr requested a review from waheedahmed July 10, 2019 17:35
Comment thread common/lib/xmodule/xmodule/capa_module.py Outdated
@uzairr
uzairr force-pushed the LEARNER-3761/capa-grading-exception branch from 987d40a to 733a3b4 Compare July 24, 2019 09:55
@uzairr
uzairr requested a review from a team July 24, 2019 09:55
@uzairr
uzairr force-pushed the LEARNER-3761/capa-grading-exception branch 2 times, most recently from ebf208f to 161683b Compare July 24, 2019 13:47

@waheedahmed waheedahmed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Once all tests passes.

Cuurently, grading endpoints in capa module are vulnerable as they
are not restricted.To avoid it, changes have been made so that
they are available only for logged-in users.

LEARNER-3761
@uzairr
uzairr force-pushed the LEARNER-3761/capa-grading-exception branch from 161683b to 9276aac Compare July 24, 2019 14:20
@uzairr

uzairr commented Jul 24, 2019

Copy link
Copy Markdown
Contributor Author

jenkins run bokchoy

@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@uzairr
uzairr merged commit 408ca56 into master Jul 25, 2019
@uzairr
uzairr deleted the LEARNER-3761/capa-grading-exception branch July 25, 2019 09:23
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, July 26, 2019.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants