Unicode changes to support R to L script - #2137
Conversation
There was a problem hiding this comment.
This seems unrelated to the unicode changes.
There was a problem hiding this comment.
it select yaml files based on language. I can remove it to be added till we figure out the yaml files.
|
@jzoldak, can you rebase this pull request? |
|
No prob. Will rebase again tonight.
|
There was a problem hiding this comment.
Why import os? It doesn't look like it's being used anywhere in this file.
|
Once this PR is rebased and the tests pass, I'm giving it a 👍. The only issues I found were minor nitpicks. |
|
@abdoosh00 I will squash commits then rebase to current edx/master. |
|
Sounds good Jay...is my rebase messed up again? :s
|
|
@abdoosh00 no, it wasn't messed up, just getting stale. We needed to get it up to date so it could be current with master and also make sure that this branch had some platform changes we needed to continue building correctly on our jenkins server. Please delete the branch locally then pull again (or otherwise force pull) in order to get the rebase changes that I force pushed. |
|
Ok, i thought this was #2138 (the html changes one) cuz thats the one i
|
|
@abdoosh00 I rebased but could not get test results because the total number of pylint violations exceeded our threshold that we have set on the Jenkins server. I just added another commit that fixed these. |
|
@jzoldak could you please force push your last changes again, I hope you didn't delete it already :s. I forced push to feature/rtl_sass branch and it pushed to both branches. is there a way to specify the exact branch to push to only? or do I have to make sure that everything is up-to-date before doing a force push? |
|
@abdoosh00 you need to change your git push default to 'simple' or 'current' so that it will only push the branch that you're on. See https://www.kernel.org/pub/software/scm/git/docs/git-config.html. You can do this with Unfortunately I'm traveling and won't have access to the machine that I have a copy of your fork of the repo on until Tuesday. :( You might be able to recover with your version of the repo using your git reflog. A git expert should be able to help you with this, maybe ask @singingwolfboy? |
|
@singingwolfboy @jzoldak All should be fine now here and on #2138 , tests passed and comments responded to as required. |
|
I'd like to help with some unicode problems that you didn't cover in this PR, do I need to create new PR or post it here? |
|
You can tell me about it to fix it. What problems? Did you test this PR and
|
4 participants
We are separating out the QRF PR into discrete features.
This is just the unicode changes.