Skip to content

Studio Component Editor Tweaks - #21538

Merged
davestgermain merged 1 commit into
masterfrom
dcs/component-tweaks
Sep 26, 2019
Merged

Studio Component Editor Tweaks#21538
davestgermain merged 1 commit into
masterfrom
dcs/component-tweaks

Conversation

@davestgermain

@davestgermain davestgermain commented Sep 3, 2019

Copy link
Copy Markdown
Contributor

@davestgermain
davestgermain requested a review from a team September 3, 2019 14:37
@davestgermain
davestgermain force-pushed the dcs/component-tweaks branch 2 times, most recently from e539b6c to 9f98227 Compare September 11, 2019 14:15
ormsbee
ormsbee reviewed Sep 12, 2019
View reviewed changes

@ormsbee ormsbee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is labeled as a WIP, so I'll check back again when it's ready for final review. Everything seems reasonable though. My only high level comment is that this is three different tickets of work, and that it would be better to deliver as different PRs as well (less risk, easier to track down changes, faster user feedback, etc.)

Comment thread cms/templates/widgets/problem-edit.html Outdated
@davestgermain
davestgermain force-pushed the dcs/component-tweaks branch 2 times, most recently from aafd54d to b99d45f Compare September 17, 2019 13:57
marcotuts
marcotuts suggested changes Sep 17, 2019
View reviewed changes

@marcotuts marcotuts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 different minor changes flagged here, mostly small styling notes. the first one is the largest as once the modals are 95% for all component editing views it might require testing / review of all the other modals before final merge.

Comment thread cms/static/sass/elements/_modal-window.scss Outdated
Comment thread common/lib/xmodule/xmodule/css/problem/edit.scss Outdated
Comment thread common/lib/xmodule/xmodule/css/problem/edit.scss Outdated
Comment thread cms/static/js/views/modals/edit_xblock.js Outdated
Comment thread cms/static/js/spec/views/modals/edit_xblock_spec.js Outdated
Comment thread common/lib/xmodule/xmodule/css/problem/edit.scss Outdated
Comment thread cms/templates/widgets/problem-edit.html Outdated
@davestgermain davestgermain changed the title [WIP] Studio Component Editor Tweaks Studio Component Editor Tweaks Sep 25, 2019
@davestgermain

davestgermain commented Sep 25, 2019

Copy link
Copy Markdown
Contributor Author

jenkins run bokchoy python quality

@davestgermain

davestgermain commented Sep 25, 2019

Copy link
Copy Markdown
Contributor Author

jenkins run python
jenkins run quality

@davestgermain
davestgermain force-pushed the dcs/component-tweaks branch 2 times, most recently from 8cb995a to 81e2b22 Compare September 25, 2019 15:53
ormsbee
ormsbee approved these changes Sep 25, 2019
View reviewed changes

@ormsbee ormsbee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question on some commented code, but otherwise LGTM. Please squash and add some context from the JIRA ticket into the commit message (what was done at a feature level and why), and let's merge. 😄

Comment thread cms/static/js/views/modals/edit_xblock.js Outdated
@davestgermain
davestgermain force-pushed the dcs/component-tweaks branch 2 times, most recently from 8a449d0 to 307b998 Compare September 25, 2019 21:06
Dave St.Germain
TNL-6920 Component Editor Efficiency Improvements
ea3232f 
* Enlarges component modal for easier editing
* Allows display name to be edited in place
* Improves markdown button labeling
* Moves markdown cheatsheet to the edit modal, for quick reference
@edx-status-bot

edx-status-bot commented Sep 26, 2019

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@davestgermain
davestgermain merged commit 2602678 into master Sep 26, 2019
@davestgermain
davestgermain deleted the dcs/component-tweaks branch September 26, 2019 14:05
@edx-pipeline-bot

edx-pipeline-bot commented Sep 26, 2019

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Friday, September 27, 2019.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 27, 2019

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ormsbee ormsbee ormsbee approved these changes
+1 more reviewer
@marcotuts marcotuts marcotuts requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davestgermain @edx-status-bot @edx-pipeline-bot @ormsbee @marcotuts