BOM-897: add newrelic metrics and trace details - #22956
Merged
Merged
Conversation
feanil
approved these changes
Jan 28, 2020
robrap
force-pushed
the
robrap/BOM-897-add-trace-info
branch
2 times, most recently
from
January 28, 2020 16:46
15541b8 to
39f1a6e
Compare
Add newrelic metrics and trace details to determine performance issue in CourseListView. BOM-897
robrap
force-pushed
the
robrap/BOM-897-add-trace-info
branch
from
January 28, 2020 17:44
39f1a6e to
26d4cc6
Compare
|
Your PR has finished running tests. There were no failures. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add newrelic metrics and trace details to determine performance issue
in CourseListView.
BOM-897
Please consider the following when opening a pull request:
In each commit, include description that could help a developer
several months from now.
make upgrade, run as close to the time of merging as possibleto avoid accidentally downgrading someone else's package.
Put the output of
make upgradein its own separate commit,decoupled from other code changes.
automated testing isn't a substitute for manual verification.
Code that is amenable to refactoring and improvement benefits all platform developers,
especially given the size and scope of edx-platform.
Consult existing Architectural Decision Records (ADRs),
including those concerning the app(s) you are changing and
those concerning edx-platform as a whole.