Report iframed courseware content dimensions to parent window - #22972
Conversation
| </nav> | ||
| % endif | ||
|
|
||
| <script type="text/javascript"> |
There was a problem hiding this comment.
Why not consolidate this with the earlier iframe check? Appending the <base> tag can happen here, right?
There was a problem hiding this comment.
It can, I just thought repeating myself to keep the functionality isolated would be good. Also it's worth noting that the base tag script needs to be in the head. Not a strong reason though. Let me know if you prefer combining them.
There was a problem hiding this comment.
I put it at the bottom originally so that most of the page would be loaded by the time it ran. It may not be important, but keeping it there may cut down on events as things resize and fill in during load.
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
5 participants
https://openedx.atlassian.net/browse/TNL-7044