Skip to content

BOM-1264: add third-party-auth scope and usage - #23135

Merged
jinder1s merged 21 commits into
masterfrom
robrap/BOM-1264-DOT-third-party-auth
Feb 21, 2020
Merged

BOM-1264: add third-party-auth scope and usage#23135
jinder1s merged 21 commits into
masterfrom
robrap/BOM-1264-DOT-third-party-auth

Conversation

@robrap

@robrap robrap commented Feb 18, 2020

Copy link
Copy Markdown
Contributor

See two new ADRs in this PR to understand the purpose of this PR:
11. More General Scope Filter Support
12. Scope and filter for Third-Party Auth

BOM-1264

@robrap
robrap requested a review from a team February 18, 2020 21:37
Comment thread common/djangoapps/third_party_auth/api/permissions.py
@robrap robrap changed the title WIP: add third-party-auth scope and usage BOM-1264: add third-party-auth scope and usage Feb 20, 2020
@robrap
robrap force-pushed the robrap/BOM-1264-DOT-third-party-auth branch from 35e242d to 86c0fd1 Compare February 20, 2020 15:41
feanil and others added 11 commits February 20, 2020 11:09
Rather than manually setting the permission class we previously
explicitly raised a PermissionDenied exception.  The way DRF
permissoning logic works, if we use the WWW-Authenticate header in the
highest priority auth class, it will return a 401 instead of a 403.
Ensure that the filters we add to the application access model make it
into the JWT correctly.

@ddt.data(
(True, 200),
(False, 401)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: add a trailing comma.

@jinder1s

Copy link
Copy Markdown
Contributor

jenkins run python

@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@jinder1s
jinder1s merged commit 372d2e9 into master Feb 21, 2020
@jinder1s
jinder1s deleted the robrap/BOM-1264-DOT-third-party-auth branch February 21, 2020 16:25
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants