Skip to content

Swap courseware-mfe CourseWaffleFlag with ExperimentWaffleFlag - #23429

Merged
abutterworth merged 5 commits into
masterfrom
abutterworth/courseware-mfe-experiment-toggle
Mar 23, 2020
Merged

Swap courseware-mfe CourseWaffleFlag with ExperimentWaffleFlag#23429
abutterworth merged 5 commits into
masterfrom
abutterworth/courseware-mfe-experiment-toggle

Conversation

@abutterworth

@abutterworth abutterworth commented Mar 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

TNL-7000

Use ExperimentWaffleFlag instead of CourseWaffleFlag for its user bucketing functionality. More info here.

Relates to #23016

@abutterworth
abutterworth requested a review from a team March 17, 2020 15:02
ormsbee
ormsbee requested changes Mar 17, 2020
View reviewed changes
Comment thread lms/djangoapps/courseware/toggles.py Outdated
@abutterworth
abutterworth requested a review from ormsbee March 17, 2020 15:30
ormsbee
ormsbee reviewed Mar 17, 2020
View reviewed changes
Comment thread lms/djangoapps/courseware/toggles.py Outdated
ormsbee
ormsbee reviewed Mar 17, 2020
View reviewed changes
Comment thread lms/djangoapps/courseware/toggles.py Outdated
stvstnfrd
stvstnfrd reviewed Mar 18, 2020
View reviewed changes
Comment thread lms/djangoapps/courseware/views/index.py Outdated
mikix
mikix reviewed Mar 19, 2020
View reviewed changes
Comment thread lms/djangoapps/experiments/flags.py Outdated
Comment thread lms/djangoapps/courseware/views/index.py Outdated
@edx-status-bot

edx-status-bot commented Mar 19, 2020

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@abutterworth
abutterworth merged commit 1f59463 into master Mar 23, 2020
@abutterworth
abutterworth deleted the abutterworth/courseware-mfe-experiment-toggle branch March 23, 2020 17:46
@edx-pipeline-bot

edx-pipeline-bot commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot

edx-pipeline-bot commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot

edx-pipeline-bot commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ormsbee ormsbee ormsbee approved these changes
@davidjoy davidjoy Awaiting requested review from davidjoy
@davestgermain davestgermain Awaiting requested review from davestgermain
+2 more reviewers
@mikix mikix mikix left review comments
@stvstnfrd stvstnfrd stvstnfrd left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@abutterworth @edx-status-bot @edx-pipeline-bot @ormsbee @mikix @stvstnfrd