Skip to content

ARCHBOM-1105: fix direct assignment error - #23708

Merged
robrap merged 2 commits into
masterfrom
robrap/fix-django-2-issues
Apr 14, 2020
Merged

ARCHBOM-1105: fix direct assignment error#23708
robrap merged 2 commits into
masterfrom
robrap/fix-django-2-issues

Conversation

@robrap

@robrap robrap commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

Fix for:
TypeError: Direct assignment to the forward side of a many-to-many set
is prohibited. Use permissions.set() instead.

ARCHBOM-1105

robrap and others added 2 commits April 13, 2020 17:06
Fix for:
TypeError: Direct assignment to the forward side of a many-to-many set
is prohibited. Use permissions.set() instead.

ARCHBOM-1105
@robrap
robrap requested a review from a team April 14, 2020 07:32
fields=[
('id', models.AutoField(verbose_name='ID', serialize=False, auto_created=True, primary_key=True)),
('mode', models.CharField(help_text='The course mode for this badge image. For example, "verified" or "honor".', unique=True, max_length=125)),
('icon', models.ImageField(help_text='Badge images must be square PNG files. The file size should be under 250KB.', upload_to=b'badges', validators=[validate_badge_image])),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upload_to a string instead of bytes

@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@awais786

awais786 commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

@robrap in this PR 1 model was removed without adding a migration and test was skipped. Thats why new migrations are coming in your branch.

@awais786

Copy link
Copy Markdown
Contributor
Migrations for 'student':
  common/djangoapps/student/migrations/0032_auto_20200414_0839.py
    - Remove field changed_by from logoutviewconfiguration
    - Delete model LogoutViewConfiguration
Migrations for 'edx_when':
  /edx/app/edxapp/venvs/edxapp/lib/python3.5/site-packages/edx_when/migrations/0007_auto_20200414_0839.py
    - Change Meta options on datepolicy

@awais786

Copy link
Copy Markdown
Contributor

@robrap I have verified migrations are now running on sandbox. Please verify or let me know if there are any other migrations causing issues

@robrap
robrap merged commit e56eace into master Apr 14, 2020
@robrap
robrap deleted the robrap/fix-django-2-issues branch April 14, 2020 14:53
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants