Fix all stylelint errors - #23920
Conversation
For any errors that fixing would require changing the output of the css disable stylelint for that line instead of modifying.
Make stylelint quality check pass when there are no errors
| This will return the number in the last line of a file. | ||
| It is returning only the value (as a floating number). | ||
| """ | ||
| last_line = _get_report_contents(filename, file_type, last_line_only=True).strip() |
There was a problem hiding this comment.
This line throw an error when there are no lint errors
| report_contents = _get_report_contents(filename, file_type, last_line_only=True) | ||
|
|
||
| if report_contents is None: | ||
| return 0 |
There was a problem hiding this comment.
Returning 0 as the count if there is no content. Curious if this generates concern from anyone.
There was a problem hiding this comment.
Indeed, this generates concern
There was a problem hiding this comment.
As it turns out, if the stylelint command is not found, then the report ends up being empty.
|
|
||
| .nav-account-user { | ||
| .title { | ||
| max-width: ($baseline*10.5); |
There was a problem hiding this comment.
Seems odd that this just got deleted?
There was a problem hiding this comment.
I deleted it because it's redeclared on 137
|
We could but I thought there might be a reason it’s there. You think we
should remove it?
…On Wed, May 6, 2020 at 2:26 PM David Joy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cms/static/sass/_base.scss
<https://github.com/edx/edx-platform/pull/23920#discussion_r421001869>:
> @@ -385,9 +386,9 @@ dl {
}
// page metadata/action bar
- .metadata {
+ // .metadata {
Can't just delete this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/edx/edx-platform/pull/23920#pullrequestreview-406877208>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMKMPKCV3TGZEPKKNA4DILRQGTXBANCNFSM4M2SOCKQ>
.
|
| // Breadcrumbs | ||
|
|
||
| -----------------*/ | ||
| // ----------------- |
There was a problem hiding this comment.
Why is this also changing comment style?
Not a huge deal, but just to note, this now means the empty lines above are now outside of the comment(s), instead of inside. 🤷
There was a problem hiding this comment.
The linter doesn't allow comments like this one it seems.
|
Your PR has finished running tests. There were no failures. |
| // ==================== | ||
|
|
||
| // CASE: less than or equal to IE7 | ||
| .lte7 { |
| // Breadcrumbs | ||
|
|
||
| -----------------*/ | ||
| // ----------------- |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
6 participants
For any errors that fixing would require changing the output of the css, this PR disables stylelint for that line instead of modifying. Example:
Rather than fixing the selector
Basically, if it was broken, leave it broken for now. This approach should prevent any unexpected changes to the css output.
FYI @AmalBas