Ratelimit the registration endpoint - #24664
Merged
Merged
Conversation
uzairr
force-pushed
the
ratelimit-registration-api
branch
from
August 5, 2020 12:20
d86f962 to
9ba6f27
Compare
Contributor
Author
|
jenkins run python |
uzairr
force-pushed
the
ratelimit-registration-api
branch
5 times, most recently
from
August 7, 2020 11:27
de399ab to
dce6953
Compare
Contributor
|
jenkins run python |
waheedahmed
force-pushed
the
ratelimit-registration-api
branch
from
August 19, 2020 11:43
dce6953 to
883d42f
Compare
waheedahmed
reviewed
Aug 19, 2020
waheedahmed
suggested changes
Aug 20, 2020
uzairr
force-pushed
the
ratelimit-registration-api
branch
from
August 20, 2020 12:49
883d42f to
4bd09a0
Compare
uzairr
force-pushed
the
ratelimit-registration-api
branch
from
August 20, 2020 13:38
4bd09a0 to
7bc17c7
Compare
waheedahmed
approved these changes
Aug 21, 2020
|
Your PR has finished running tests. There were no failures. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registration pages display whether usernames and email addresses exist or have already been registered. An attacker can therefore guess or brute force a series of names to enumerate valid users.To overcome this, registration validation endpoints are rate-limited up to 30 requests/user in a week.
https://openedx.atlassian.net/browse/PROD-880