Alert banner for proctoring settings error - #24960
Merged
Merged
Conversation
Contributor
Author
Advanced Settings
Course Outline
|
zacharis278
marked this pull request as ready for review
September 14, 2020 13:20
schenedx
suggested changes
Sep 14, 2020
schenedx
left a comment
schenedx
left a comment
Contributor
There was a problem hiding this comment.
I want to see new unit test for the changed behavior
| self.assertIn('proctoring_escalation_email', test_model) | ||
|
|
||
| @override_settings( | ||
| PROCTORING_BACKENDS={ |
Contributor
There was a problem hiding this comment.
While it's nice to remove no longer used unit tests, but I believe you should add unit test for the added warning messages on course settings.
alangsto
approved these changes
Sep 14, 2020
alangsto
left a comment
alangsto
left a comment
Contributor
There was a problem hiding this comment.
I agree with Simon's comment about the unit tests, and also had a small suggestion for wording!
Contributor
Author
|
jenkins run python |
|
Your PR has finished running tests. There were no failures. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MST-359
@edx/masters-devs-cosmonauts