Skip to content

[BD-03] [TNL-2624] [BB-3168] Piazza Plugin for discussions - #25552

Closed
xitij2000 wants to merge 11 commits into
openedx:masterfrom
open-craft:kshitij/piazza-plugin
Closed

[BD-03] [TNL-2624] [BB-3168] Piazza Plugin for discussions#25552
xitij2000 wants to merge 11 commits into
openedx:masterfrom
open-craft:kshitij/piazza-plugin

Conversation

@xitij2000

@xitij2000 xitij2000 commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

Adds a plugin to enable Piazza discussions in the discussions tab.
Build on https://github.com/edx/edx-platform/pull/24584

Dependencies: https://github.com/edx/edx-platform/pull/24584

Screenshots: Always include screenshots if there is any change to the UI.

Sandbox URL: sandbox is being provisioned.

Test Instructions:

  • After checking out this branch run pip install -e . in the edx-platform directory in the lms and studio containers so that changes to setup.py are picked up.
  • Visit http://localhost:18000/admin/discussions/discussionproviderconfig/ and add a new provider config for Piazza.
    • Give it any name
    • Select "Piazza" as the discussion provider
    • Set the config to {"consumer_key":"piazza.sandbox","consumer_secret":"test_only_secret"}
    • Leave the rest empty and save.
  • Visit http://localhost:18000/admin/discussions/learningcontextdiscussionconfig/ and add a new object
    • Enter a valid course id in the Learning Context field
    • Enabled should be checked
    • Select the new provider.
    • Leave the overrides blank.
  • Visit the course page on the LMS
  • Make sure the Discussion tab is visible
  • Clicking on the tab should load up an Piazza in an iframe.

Reviewers

  • (OpenCraft internal reviewer's GitHub username goes here)
  • edX reviewer[s] TBD

Settings

EDXAPP_FEATURES:
  ENABLE_COMBINED_LOGIN_REGISTRATION: true

FORUM_VERSION: open-release/juniper.master
forum_version: open-release/juniper.master

@openedx-webhooks

openedx-webhooks commented Nov 9, 2020

Copy link
Copy Markdown

Thanks for the pull request, @xitij2000! I've created BLENDED-665 to keep track of it in Jira.

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 9, 2020
@xitij2000 xitij2000 changed the title Kshitij/piazza plugin [BD-03] [TNL-2624] [BB-3168] Piazza Plugin for discussions Nov 9, 2020
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Nov 9, 2020
This is the first of many steps required to enabled pluggable Discussion apps.
This first step adds a configuration system and API that can be used by plugins.
This will allow creating a link between a course and a discussion provider that
will be utilised in future PRs to specify which plugin to use for a particular
course's dicussions.
Fix for setting provider to none
@xitij2000
xitij2000 force-pushed the kshitij/piazza-plugin branch from 4b6a996 to aace26c Compare November 10, 2020 12:01
@xitij2000
xitij2000 force-pushed the kshitij/piazza-plugin branch from aace26c to 551c3f8 Compare November 10, 2020 13:10
@xitij2000
xitij2000 force-pushed the kshitij/piazza-plugin branch from fa3e46b to dd29906 Compare November 10, 2020 18:49
@xitij2000

Copy link
Copy Markdown
Contributor Author

@davidjoy This is the Piazza plugin pr. I've added testing instructions here.
This is still WIP, but it works, and the overall approach is final. I'm working on what needs to be tested and where/how to split the responsibility of the LTI launch.
I've also made an internal PR from the same branch; open-craft#291
That PR targets the branch this is based on, so only has the relevant changes.

@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@xitij2000
xitij2000 deleted the kshitij/piazza-plugin branch December 25, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants