Skip to content

Adding custom fork celery with better logging. - #25649

Merged
awais786 merged 1 commit into
masterfrom
awais786/upgrade-celery-fork
Nov 20, 2020
Merged

Adding custom fork celery with better logging.#25649
awais786 merged 1 commit into
masterfrom
awais786/upgrade-celery-fork

Conversation

@awais786

@awais786 awais786 commented Nov 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adding custom fork celery with better logging PR

Sandbox https://upgradeceleryfork.sandbox.edx.org/
flower http://ec2-54-226-244-218.compute-1.amazonaws.com:5555/

Some logs appearing on sandbox

/edx/var/log/supervisor/lms_default_1-stderr.log:2020-11-19 19:03:36,089 INFO 24229 [celery.loaders.base] [user None] [ip None] base.py:270 - EDX-CELERY-FindingTasksModule: Finding tasks module for lms.djangoapps.ccx
/edx/var/log/supervisor/lms_default_1-stderr.log:2020-11-19 19:03:36,090 INFO 24229 [celery.loaders.base] [user None] [ip None] base.py:288 - EDX-CELERY-TaskModuleImported: lms.djangoapps.ccx.tasks module is imported
/edx/var/log/supervisor/lms_default_1-stderr.log:2020-11-19 19:03:36,091 INFO 24229 [celery.loaders.base] [user None] [ip None] base.py:270 - EDX-CELERY-FindingTasksModule: Finding tasks module for openedx.core.djangoapps.ccxcon
/edx/var/log/supervisor/lms_default_1-stderr.log:2020-11-19 19:03:36,092 INFO 24229 [celery.loaders.base] [user None] [ip None] base.py:288 - EDX-CELERY-TaskModuleImported: openedx.core.djangoapps.ccxcon.tasks module is imported
/edx/var/log/supervisor/lms_default_1-stdout.log:EDX-CELERY-ConfigForAutodiscover: django.contrib.auth's config added for autodiscovery
/edx/var/log/supervisor/lms_default_1-stdout.log:EDX-CELERY-ConfigForAutodiscover: django.contrib.contenttypes's config added for autodiscovery
/edx/var/log/supervisor/lms_default_1-stdout.log:EDX-CELERY-ConfigForAutodiscover: django.contrib.humanize's config added for autodiscovery
/edx/var/log/supervisor/lms_default_1-stdout.log:EDX-CELERY-ConfigForAutodiscover: django.contrib.messages's config added for autodiscovery

awais786
awais786 commented Nov 19, 2020
View reviewed changes
Comment thread requirements/edx/base.txt Outdated

@awais786 awais786 Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just released fews hours ago.
https://pypi.org/project/django-celery-results/2.0.0/

@awais786
awais786 force-pushed the awais786/upgrade-celery-fork branch from 41478f7 to 6586651 Compare November 19, 2020 19:13
@awais786
awais786 requested a review from jmbowman November 19, 2020 19:33
@awais786
awais786 marked this pull request as ready for review November 19, 2020 19:41
awais786
awais786 commented Nov 19, 2020
View reviewed changes
Comment thread requirements/edx/base.txt Outdated

@awais786 awais786 Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why its removing from here.

@jmbowman jmbowman Nov 20, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you ran make upgrade under Python 3.8, whereas Jenkins is still using 3.5 since we haven't turned off testing against 3.5 yet.

@awais786 awais786 Nov 20, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes we ran this on our make upgrade machine.

awais786
awais786 commented Nov 19, 2020
View reviewed changes
Comment thread requirements/edx/base.txt Outdated

@awais786 awais786 Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@awais786
awais786 force-pushed the awais786/upgrade-celery-fork branch from 53f58c8 to 1ca39fc Compare November 20, 2020 12:56
@awais786
awais786 force-pushed the awais786/upgrade-celery-fork branch from 12b6a3b to 4bf9bb5 Compare November 20, 2020 13:02
@edx-status-bot

edx-status-bot commented Nov 20, 2020

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@awais786
awais786 merged commit e153778 into master Nov 20, 2020
@awais786
awais786 deleted the awais786/upgrade-celery-fork branch November 20, 2020 16:53
@edx-pipeline-bot

edx-pipeline-bot commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@UsamaSadiq UsamaSadiq mentioned this pull request Dec 14, 2020
Merged
@jmbowman jmbowman mentioned this pull request Oct 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@jmbowman jmbowman jmbowman approved these changes
@mzulqarnain1 mzulqarnain1 mzulqarnain1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@awais786 @edx-status-bot @edx-pipeline-bot @jmbowman @mzulqarnain1