Skip to content

Fixes devstack settings to work with new version of debug toolbar - #2627

Merged
davestgermain merged 1 commit into
masterfrom
dcs/fix-devstack-toolbar
Feb 18, 2014
Merged

Fixes devstack settings to work with new version of debug toolbar#2627
davestgermain merged 1 commit into
masterfrom
dcs/fix-devstack-toolbar

Conversation

@davestgermain

Copy link
Copy Markdown
Contributor

@singingwolfboy
Your recent PR to upgrade the debug toolbar broke devstack because the SHOW_TOOLBAR_CALLBACK setting now expects a string rather than a function.

@flowerhack

Copy link
Copy Markdown
Contributor

Does this fix work locally for you? I'm having the issue you described, but when I cherry-picked this commit I got the following error when I try to load the LMS:

Traceback (most recent call last):
File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 89, in get_response
response = middleware_method(request)
File "/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/debug_toolbar/middleware.py", line 46, in process_request
show_toolbar = getattr(import_module(mod_path), func_name)
AttributeError: 'module' object has no attribute 'should_show_debug_toolbar'

@davestgermain

Copy link
Copy Markdown
Contributor Author

yeah, I was a bit hasty. did you cherry pick 5877e84? that should work

@flowerhack

Copy link
Copy Markdown
Contributor

Ah, yes, the new commit works :) Thanks so much for getting this!

⛵ as soon as tests pass

Comment thread common/djangoapps/util/request.py Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this

@davestgermain

Copy link
Copy Markdown
Contributor Author

OK, I added to cms settings as well.

@gwprice

gwprice commented Feb 18, 2014

Copy link
Copy Markdown

👍

davestgermain pushed a commit that referenced this pull request Feb 18, 2014
Fixes devstack settings to work with new version of debug toolbar
@davestgermain
davestgermain merged commit b408650 into master Feb 18, 2014
@davestgermain
davestgermain deleted the dcs/fix-devstack-toolbar branch February 18, 2014 19:55
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Dec 21, 2018
…-2622_2

Develop/gacco/dogwood/jast 2622 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants