[TSD] Added annotations for DISABLE_COURSE_CREATION feature flag - #26941
Conversation
|
Thanks for the pull request, @arslanashraf7! I've created OSPR-5661 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@arslanashraf7 Thank you for your contribution. @eLRuLL @BbrSofiane Could you please review? |
|
@pdpinch FYI. |
BbrSofiane
left a comment
There was a problem hiding this comment.
@arslanashraf7 Can you be a bit more descriptive in the toggle_description? Does it remove the 'New Course' button on the studio side?
4861ee8 to
b32d468
Compare
|
@BbrSofiane, You're correct it hides the "New Course" button the I missed to add this, I've updated the annotations & PR description. Please have a look & let me know what you think of it now. |
BbrSofiane
left a comment
There was a problem hiding this comment.
Nice @arslanashraf7! @edx/doc-a-thon-reviewers this is ready to be merged,
|
@felipemontoya @bradenmacdonald Please merge when you have a chance. |
|
@arslanashraf7 can you update the commit message to follow the Conventional Commits guidelines? I think all you need is to put "docs: " at the beginning of the commit message. |
b32d468 to
9e41379
Compare
@pdpinch, Thanks for pointing it out. I've updated the commit message as per the conventional commit guidelines. |
|
Your PR has finished running tests. There were no failures. |
|
@arslanashraf7 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
@pdpinch, thanks for taking out the time to review and merge this PR. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
@BbrSofiane @pdpinch Thank you both! |
|
@arslanashraf7 Are you in Discourse? If yes, please let me know your username and I will grant you a badge for your participation in Doc-a-thon! |
Related ticket:
mitodl#244
Description
Adds annotations for
DISABLE_COURSE_CREATIONfeature flag.Other information
There are a few points of explanation for this PR,
cms/envs/common.pyand it was only used with a get call with default value asFalse, so for the sake of consistency I've added it tocms/envs/common.py.toggle_creation_dateis based on the earliest usage of this flag I could find in the codebase.toggle_ticketsis because there was no specific ticket that would add this flag specifically, there are multiple PR that just have the usage of this.