fix: Hide enterprise/login button if enterprise integration disabled. - #27130
Merged
waheedahmed merged 2 commits intoApr 15, 2021
Conversation
|
Thanks for the pull request, @idegtiarov! I've created OSPR-5687 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
open-source-contribution
idegtiarov
force-pushed
the
fix/hide_enterprise_login
branch
from
March 24, 2021 19:16
174603a to
a598fd0
Compare
Contributor
|
@idegtiarov Thank you for your contribution. Please let me know once it is ready for our review. |
idegtiarov
force-pushed
the
fix/hide_enterprise_login
branch
2 times, most recently
from
March 26, 2021 06:16
bf67d93 to
e3e2022
Compare
idegtiarov
force-pushed
the
fix/hide_enterprise_login
branch
from
April 3, 2021 12:06
e3e2022 to
d703601
Compare
idegtiarov
marked this pull request as ready for review
April 3, 2021 12:42
openedx-webhooks
added
needs triage
and removed
waiting on author
waheedahmed
reviewed
Apr 14, 2021
waheedahmed
left a comment
waheedahmed
left a comment
Contributor
There was a problem hiding this comment.
Couple of suggestions otherwise LGTM.
[BTR-52](https://openedx.atlassian.net/browse/BTR-52) Fix an issue with existing button for enterprise login on the login page when enterprise integration is disabled.
idegtiarov
force-pushed
the
fix/hide_enterprise_login
branch
5 times, most recently
from
April 14, 2021 16:08
c217ccf to
ae5efb0
Compare
idegtiarov
force-pushed
the
fix/hide_enterprise_login
branch
from
April 14, 2021 17:31
ae5efb0 to
3e14d34
Compare
|
Your PR has finished running tests. There were no failures. |
waheedahmed
approved these changes
Apr 15, 2021
waheedahmed
left a comment
waheedahmed
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking the suggestions 👍
|
@idegtiarov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
cmltaWt0
pushed a commit
to raccoongang/edx-platform
that referenced
this pull request
Jun 4, 2021
…openedx#27130) * fix: Hide enterprise/login button if enterprise integration disabled. [BTR-52](https://openedx.atlassian.net/browse/BTR-52) Fix an issue with existing button for enterprise login on the login page when enterprise integration is disabled. * Address review comments
pdpinch
pushed a commit
that referenced
this pull request
Jun 7, 2021
…#27130) (#27834) * fix: Hide enterprise/login button if enterprise integration disabled. [BTR-52](https://openedx.atlassian.net/browse/BTR-52) Fix an issue with existing button for enterprise login on the login page when enterprise integration is disabled. Co-authored-by: Igor Degtiarov <igor.degtiarov@raccoongang.com>
dmitry-viskov
pushed a commit
to weaveeducation/edx-platform
that referenced
this pull request
Jun 8, 2021
…openedx#27130) (openedx#27834) * fix: Hide enterprise/login button if enterprise integration disabled. [BTR-52](https://openedx.atlassian.net/browse/BTR-52) Fix an issue with existing button for enterprise login on the login page when enterprise integration is disabled. Co-authored-by: Igor Degtiarov <igor.degtiarov@raccoongang.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue with an existing button for enterprise login on the login page
when enterprise integration is disabled.
BTR-52