Add experimental crowdsource hinter module - #275
Conversation
Conflicts: common/static/coffee/src/logger.coffee
Added moderation feature - you can now choose to hold all hints for moderator approval before showing.
… the crowdsource hinter module. (Old tests no longer cover all the code, now that moderation has been added.)
…ier to read. Fixed database non-initialization bug in crowdsource hinter module.
…nsitive. Still very hacky.
Fixed some bugs in the tests for crowdsourced hinter.
Hinter now displays vote count after voting. Began testing templates.
Chiseled a little at writing template tests.
|
@fephsun I am going to do a first review here |
There was a problem hiding this comment.
Add an intro docstring, describing what the module does in very general terms. Also make add a line at the beginning that highlights that the module is experimental and should not be used to create content at the moment (because we may change things, etc).
|
Diff coverage: Please add more test coverage before merging. |
|
@wedaly was your coverage message automated? Cool! |
There was a problem hiding this comment.
We are breaking early because we only expect one child, correct? If so add a little comment. If we are only expecting one child we should add that to the class documentation.
|
This is a meta comment, so I am putting it here. I normally find very useful to add some blank lines to separate logical blocks of code in function. It improves readability a bit (I read somewhere there was a study showing that it improved code comprehension), but it is also a good indicator of when you have to refactor a function. If there are too many logical blocks within a function, it is asking to be broken down and refactored into smaller methods. Here is an example I found with a quick search: http://programmers.stackexchange.com/a/17325 (see how the bad whitespace example gets refactored down). |
There was a problem hiding this comment.
minor: make_capa_answer_hashable?
There was a problem hiding this comment.
Could you add a comment on why you access [answer][pk][1]?
Began enforcing one-vote-per-person. This can be disabled with debug="True" in the <crowdsource_hinter> tag. Started tests of the hint manager.
There was a problem hiding this comment.
Let me see if I follow, problem_id is the definition_id of the hinter module, correct? If so, the variable name makes it a bit confusing.
There was a problem hiding this comment.
You can use .on instead of .live. I think .live has been deprecated. (Check if the version of jQuery that we use supports it first).
|
@fephsun looks like some tests are failing now. |
…ents - this lets us test the hint manager.
|
Hi a drive-by comment, if you don't mind. Have you thought about authoring via Studio yet? I see some sample XML which wraps a new XModule around a Problem XModule, so there could be complexities with how this will be authored in Studio, which is used by a vast majority of course creators. If not, you might want to drop @markchang @cahrens a quick note to discuss. Thanks, apologies for the intrusion. |
…anager. Expanded tests of hint_manager. Enabled the hint_manager by default in development environments.
|
@chrisndodge Thanks for stopping by! At this stage, the module it is just an experiment. We want to collect some data and verify if the students will actually use something like this, and if so, how. I don't recommend that we make it available since it is likely to change. Unfortunately, in our current architecture we don't have a way to run experiments, or add experimental features without adding them to the main code base. |
Expanded test coverage a little.
…dded some HTML formatting to same.
Added contact info on Berkeley press release.
mattdrayer/profiler-updates: PEP8/Pylint
cherry-pick 68d9303 to master
…-sha Update SHA of MUFI XBlock
restricted oauth changes & migration files
* Commits: Submit events to the tracking logs, not just Segment
5 participants
No description provided.