build: run github actions on pull requests

[regisb]

Description

This will run mypy within GitHub actions for every pull request.

Currently, some types are annotated within edx-platform, but they are not actively enforced. This change will make sure that mypy is run for every PR.

Supporting information

See the corresponding discussion: https://discuss.openedx.org/t/dev-notes-running-mypy-on-edx-platform/4860/2
And the previous PR: https://github.com/edx/edx-platform/pull/27575

Other information

Note that running GitHub Actions for every PR might make us hit the usage limits, as installing python requirements is a costly operation.

[openedx-webhooks]

Thanks for the pull request, @regisb! I've created OSPR-5818 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[regisb]

This is ready for review.

[natabene]

@regisb Thank you for your contribution. Is this ready for a review?

[arch-bom-gocd-alerts]

📣 💥 Heads-up: You must either rebase onto master or merge master into your branch to avoid breaking the build.

We recently removed diff-quality and introduced lint-amnesty. This means that the automated quality check that has run on your branch doesn't work the same way it will on master. If you have introduced any quality failures, they might pass on the PR but then break the build on master.

This branch has been detected to not have commit 2e33565 as an ancestor. Here's how to see for yourself:

git merge-base --is-ancestor 2e335653 regisb/pr-github-actions && echo "You're all set" || echo "Please rebase onto master or merge master to your branch"

If you have any questions, please reach out to the Architecture team (either #edx-shared-architecture on Open edX Slack or #architecture on edX internal).

[natabene]

@regisb Just checking, have you had a chance to implement the feedback provided?

[regisb]

@natabene not yet! I did not have time during the past couple weeks and I'm currently on holidays. I will get back to this PR after I return.

[regisb]

This is ready for review again :)

[regisb]

Thanks for your review @mraarif! I made the suggested changes. I also managed to test CI with act:

act --reuse --workflows .github/workflows/ci-static-analysis.yml "pull_request"

I also added a typing fix such that CI can actually pass without error.

[edx-status-bot]

Your PR has finished running tests. There were no failures.

[jmbowman]

Looks good, thanks for setting this up!

[openedx-webhooks]

@regisb 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the production environment.

[timmc-edx]

FYI, one error snuck in on master while this PR was open:

openedx/core/djangoapps/content/learning_sequences/api/processors/enrollment_track_partition_groups.py:31: error: Need type annotation for "enrollment_track_groups" (hint: "enrollment_track_groups: Dict[<type>, <type>] = ...")

I think Arbi-BOM is going to take care of fixing that one.