fix: Update how the heartbeat routing key is determined. - #28065
Closed
feanil wants to merge 1 commit into
Closed
Conversation
When the heartbeat was moved to the high priority queue, the production override did not take into account the fact that the name of the high_priority queue changes in the production.py file. Update the part of production.py that sets the default routing key so that the new HIGH_PRIORITY_QUEUE name is picked up unless there is an override.
|
Your PR has finished running tests. There were no failures. |
robrap
approved these changes
Jun 30, 2021
robrap
left a comment
robrap
left a comment
Contributor
There was a problem hiding this comment.
- Was this tested or is there a way to test?
- Is this needed for Lilac?
Contributor
Author
|
Closing this because https://github.com/edx/edx-platform/pull/28066 is a better solution for this. Gonna be testing that one on a sandbox before shipping it to stage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the heartbeat was moved to the high priority queue, the production
override did not take into account the fact that the name of the
high_priority queue changes in the production.py file.
Update the part of production.py that sets the default routing key so
that the new HIGH_PRIORITY_QUEUE name is picked up unless there is an
override.
Impact: Operators
Supporting information
Jira: https://openedx.atlassian.net/browse/ARCHBOM-1821
Ticket Summary: Please investigate why sample_task tasks are stuck in a edx.core.high queue.
Deadline
None