fix: Unify required parameter checks - #28201
Merged
Merged
Conversation
crice100
force-pushed
the
crice/params
branch
2 times, most recently
from
July 16, 2021 19:40
3f39d89 to
3bf4781
Compare
MICROBA-1373
justinhynes
force-pushed
the
crice/params
branch
from
July 20, 2021 11:48
3bf4781 to
8b362f1
Compare
justinhynes
marked this pull request as ready for review
July 20, 2021 12:21
|
Your PR has finished running tests. There were no failures. |
justinhynes
approved these changes
Jul 20, 2021
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify required parameter checks for cert generation, so there's 1 place we track these.
MICROBA-1373
Depends on (should be merged after) https://github.com/edx/edx-platform/pull/28196