fix: import+export management commands - #28219
Conversation
|
Thanks for the pull request, @alex2bender! I've created OSPR-5924 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@alex2bender Thank you for joining the Open edX community! We have added your user to our records and can now review your code going forward. |
|
jenkins run all |
|
@natabene so what next? |
|
@alex2bender I have scheduled this PR for our review, though it might take a few weeks for us to get to it. Nothing more needed from your side at this point, thanks. |
|
Didn't expect that it will take so much time, haha. |
|
The team that reviews is has many OSPRs in the backlog, so, unfortunately, it will take some time, even thought the change itself might not be that big. |
|
@natabene I could review this if you'd like? |
|
@bradenmacdonald Thanks so much for offering, let me check with the owning squad, and I will get back to you asap. |
|
@bradenmacdonald It is yours, please review. Thanks again for offering. |
bradenmacdonald
left a comment
There was a problem hiding this comment.
👍 Thanks for this fix @alex2bender ! Would you be able to rebase it so I can merge it?
- I tested this: as described. I confirmed the errors are present without the fix, and this fix solves them.
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
|
Hello @bradenmacdonald ! Sorry it took so long for me to do that. |
|
Great, thanks @alex2bender! I will merge this tomorrow. |
|
Actually @alex2bender, sorry for the trouble here but can you please also edit the commit message so it starts with |
|
Your PR has finished running tests. There were no failures. |
|
@alex2bender 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description
PR provides with fix for Studio management commands:
Background
Studio Updates: The commands above are working normally
LMS Updates: None
Testing:
Run commands on an existing library with id <library_id>. Save it in /tmp and import it using staff user as owner: