Skip to content

Script for granting existing instructors creator access. - #285

Merged
cahrens merged 7 commits into
masterfrom
christina/course-create-permissions
Jun 27, 2013
Merged

Script for granting existing instructors creator access.#285
cahrens merged 7 commits into
masterfrom
christina/course-create-permissions

Conversation

@cahrens

@cahrens cahrens commented Jun 27, 2013

Copy link
Copy Markdown

No description provided.

@ghost ghost assigned chrisndodge Jun 27, 2013
Comment thread cms/djangoapps/auth/authz.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should document that this is to grandfather in existing instructors. Ideally this will only be run once, ever.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will update it.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps I should just add a task to delete this code (and the django command) at the end of this story?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although perhaps we will want to run it on edx at some point. Hmmmmm.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this kinda feels like a "Migration", but without a schema change. I don't know much about those tools to make a recommendation, maybe Dave O or Victor might have a suggestion.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All add a task to the story to delete the code if appropriate.

@chrisndodge

Copy link
Copy Markdown
Contributor

+1 after a slight doc string tweek.

@chrisndodge

Copy link
Copy Markdown
Contributor

+1 thanks for the clarification.

@chrisndodge

Copy link
Copy Markdown
Contributor

Builds failing, but it seems to be an internal Jenkins/nose error?!? Do you want to trigger another build?

@cahrens

cahrens commented Jun 27, 2013

Copy link
Copy Markdown
Author

Thanks, Chris-- I hadn't noticed. I triggered a manual build and that was fine, except for pep8 and pylint going up. I did some cleanup and will merge this assuming tests pass.

cahrens pushed a commit that referenced this pull request Jun 27, 2013
Script for granting existing instructors creator access.
@cahrens
cahrens merged commit 8207f22 into master Jun 27, 2013
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
Fixed bugs caused by modal cloning. Now, only video modals are cloned.
Kelketek referenced this pull request in open-craft/openedx-platform Oct 24, 2014
…lationship

ziafazal/api-org-groups-relationship: added groups
Yasui-ks added a commit to nttks/edx-platform that referenced this pull request Sep 16, 2015
Yasui-ks added a commit to nttks/edx-platform that referenced this pull request Sep 16, 2015
diegomillan referenced this pull request in eduNEXT/edx-platform Sep 14, 2016
Adding split mongo fixes back.

Not turning split mongo on for new courses, just adding the code that fixes tests and functionality when we do decide to turn it on
CrewS pushed a commit to CrewS/edx-platform-1 that referenced this pull request Jan 24, 2019
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
LinkedIn button size and single column for view grades button in mobile
DJkal11 pushed a commit to Abstract-Tech/edx-platform that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants