feat: add reset option to the Randomized Content Block by tinuademargaret · Pull Request #28624 · openedx/openedx-platform

tinuademargaret · 2021-09-01T21:39:30Z

Description

This adds a reset option to the randomized content block. This way students can prepare themselves for exams by answering a series of questions at random from a pre-determined set (something similar to flashcards).

We have been doing it with Python scripts within the CAPA blocks - questions and answers were included directly in the script and the reset button was changing the seed used for determining the question set. This PR introduces a similar functionality by using built-in Open edX features, thus making it more user-friendly and available for less technical course authoring teams.

Supporting information

BB-4659

A video showing this feature.

Testing instructions

Check out to this branch tinumide/add_reset_to_randomized_content_block on edx-platform.
In Studio, create a randomized content block and set the Show Reset Button option to True.
View the live version of the new block and click on the Reset Problems button on the bottom left part of the Randomized Content Block.
Verify that the page is reloaded, answers are reset and the questions are changed.

openedx-webhooks · 2021-09-01T21:39:34Z

Thanks for the pull request, @tinumide! I've created OSPR-6013 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

natabene · 2021-09-07T14:32:11Z

@tinumide Thank you for your contribution. Let me kick the checks off.

Agrendalath

@tinumide, I see that many of these comments are still not addressed.
Edit: ok, I'm seeing them now. That's odd.

Agrendalath

@tinumide, please address the remaining comment and squash the commits into one with a meaningful description.

👍

I tested this: tested that it's possible to reset and reshuffle selected children of the RCB
I read through the code
I checked for accessibility issues: n/a
Includes documentation: n/a
I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

Agrendalath · 2021-10-07T09:25:20Z

@giovannicimolin, can we add this to the OSPR list? It might need a product review.
cc: @natabene

giovannicimolin · 2021-10-07T14:49:17Z

@Agrendalath Done, I've added this to the OSPR list.

Agrendalath

@tinumide, we need these two small changes. Please squash commits after addressing them and rebase this on the master branch to ensure that the CI works correctly.

edx-status-bot · 2021-10-28T13:30:28Z

Your PR has finished running tests. There were no failures.

This adds a reset option to a Randomized Content Block (LibraryContentBlock) to allow an OpenEdx user to reset questions in a Randomized Content Block. This is achieved by adding a `Reset Problems` button to the UI of a vertical with randomized content, and a reset handler to process the request.

natabene · 2022-01-06T21:35:02Z

@tinumide Can you please sign https://openedx.org/cla? Without it we, unfortunately, cannot review and merge your code.

Agrendalath · 2022-01-07T00:41:24Z

@natabene, Tinuade is no longer working with OpenCraft. We will recreate this PR and link it for reference.

natabene · 2022-01-10T15:37:04Z

@Agrendalath I see, thanks for clarifying. Do you want me to close this PR?

Agrendalath · 2022-01-10T17:33:14Z

Closing, as we've replaced this with #29728.

cc: @natabene

openedx-webhooks · 2022-01-10T17:33:20Z

@tinumide Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks added open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Sep 1, 2021

Agrendalath reviewed Sep 2, 2021

View reviewed changes

Comment thread common/lib/xmodule/xmodule/library_content_module.py Outdated

Comment thread common/lib/xmodule/xmodule/library_content_module.py Outdated

Comment thread common/lib/xmodule/xmodule/library_content_module.py Outdated

tinuademargaret requested a review from a team September 6, 2021 02:15

tinuademargaret changed the title ~~WIP: BB-4659 Add reset option to the randomized content block~~ BB-4659 Add reset option to the randomized content block Sep 7, 2021

openedx-webhooks added needs triage and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Sep 7, 2021

natabene added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Sep 8, 2021

Agrendalath requested changes Sep 8, 2021

View reviewed changes

tinuademargaret force-pushed the tinumide/add_reset_to_randomized_content_block branch 2 times, most recently from a1003e2 to 46252f8 Compare September 15, 2021 00:56

Agrendalath requested changes Sep 16, 2021

View reviewed changes

Agrendalath requested changes Sep 20, 2021

View reviewed changes

Agrendalath reviewed Sep 20, 2021

View reviewed changes

Comment thread cms/djangoapps/contentstore/tests/test_libraries.py Outdated

Agrendalath requested changes Sep 27, 2021

View reviewed changes

Agrendalath approved these changes Oct 1, 2021

View reviewed changes

Comment thread lms/static/sass/course/courseware/_courseware.scss Outdated

tinuademargaret force-pushed the tinumide/add_reset_to_randomized_content_block branch 2 times, most recently from 58273b8 to a93a031 Compare October 6, 2021 20:49

tinuademargaret force-pushed the tinumide/add_reset_to_randomized_content_block branch from 6426866 to f33bdbb Compare October 18, 2021 12:54

Agrendalath requested changes Oct 19, 2021

View reviewed changes

Comment thread common/lib/xmodule/xmodule/library_content_module.py Outdated

Comment thread common/lib/xmodule/xmodule/library_content_module.py Outdated

tinuademargaret force-pushed the tinumide/add_reset_to_randomized_content_block branch 2 times, most recently from f01cbcc to 6aa10e9 Compare October 20, 2021 11:00

Agrendalath approved these changes Oct 27, 2021

View reviewed changes

openedx-webhooks added product review PR requires product review before merging and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 28, 2021

Agrendalath force-pushed the tinumide/add_reset_to_randomized_content_block branch from 5a01e8b to 5e88115 Compare October 28, 2021 13:01

Agrendalath changed the title ~~BB-4659 Add reset option to the randomized content block~~ feat: add reset option to the Randomized Content Block Oct 28, 2021

Agrendalath mentioned this pull request Nov 25, 2021

chore: port echo drift to lilac [BB-4704] open-craft/openedx-platform#443

Merged

tinumide and others added 3 commits January 6, 2022 17:21

reset the content of random block via AJAX without refreshing full page

218d35f

adds the missing context

4626db5

Agrendalath force-pushed the tinumide/add_reset_to_randomized_content_block branch from 35c9244 to 4626db5 Compare January 6, 2022 16:28

openedx-webhooks added the community manager review label Jan 6, 2022

tecoholic mentioned this pull request Jan 7, 2022

feat: add reset option to the Randomized Content Block #29728

Merged

Agrendalath closed this Jan 10, 2022

openedx-webhooks added rejected and removed product review PR requires product review before merging community manager review labels Jan 10, 2022

Agrendalath deleted the tinumide/add_reset_to_randomized_content_block branch January 10, 2022 17:33

Uh oh!

Conversation

tinuademargaret commented Sep 1, 2021 • edited by Agrendalath Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Testing instructions

Uh oh!

openedx-webhooks commented Sep 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

natabene commented Sep 7, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Agrendalath left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Agrendalath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Agrendalath commented Oct 7, 2021

Uh oh!

giovannicimolin commented Oct 7, 2021

Uh oh!

Agrendalath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

edx-status-bot commented Oct 28, 2021

Uh oh!

natabene commented Jan 6, 2022

Uh oh!

Agrendalath commented Jan 7, 2022

Uh oh!

natabene commented Jan 10, 2022

Uh oh!

Agrendalath commented Jan 10, 2022

Uh oh!

openedx-webhooks commented Jan 10, 2022

Uh oh!

Reviewers

tinuademargaret commented Sep 1, 2021 •

edited by Agrendalath

Loading

openedx-webhooks commented Sep 1, 2021 •

edited

Loading

Agrendalath left a comment •

edited

Loading