Skip to content

Revert "[BD-13] Let ModuleSystem use UserService" - #28857

Merged
ormsbee merged 1 commit into
masterfrom
revert-28440-jill/BD-13-user-service
Sep 27, 2021
Merged

Revert "[BD-13] Let ModuleSystem use UserService"#28857
ormsbee merged 1 commit into
masterfrom
revert-28440-jill/BD-13-user-service

Conversation

@ormsbee

@ormsbee ormsbee commented Sep 27, 2021

Copy link
Copy Markdown
Contributor

Reverts edx/edx-platform#28440

FYI @pomegranited and @symbolist: Reverting over issues around anonymous_student_id values. Will update with more information shortly.

@connorhaugh connorhaugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it matches the og PR. lgtm. i will keep an ear to the ground incase revert causes problems.

@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@ormsbee
ormsbee merged commit deaf80f into master Sep 27, 2021
@ormsbee
ormsbee deleted the revert-28440-jill/BD-13-user-service branch September 27, 2021 19:42
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@pomegranited

Copy link
Copy Markdown
Contributor

@ormsbee bummer :(

Could it have to do with this change? We dropped the is_pure_xblock check because that should be true for everything now, but maybe it's not? CC @symbolist

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@pomegranited

Copy link
Copy Markdown
Contributor

Hi @ormsbee , I'm away until 18 Oct, but would like to address this when I return.
Do you have any more information about what issue this caused in production?

@ormsbee

ormsbee commented Oct 13, 2021

Copy link
Copy Markdown
Contributor Author

@pomegranited: I'll post up an example before you get back. Thank you.

@pomegranited

Copy link
Copy Markdown
Contributor

Hi @ormsbee 👋 Do you have any more information about this issue? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants