fix: rtl language layout - #28861
Conversation
|
Thanks for the pull request, @meysam81! I've created OSPR-6077 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@meysam81 Thank you for your contribution! |
e51b83a to
d5574d8
Compare
shimulch
left a comment
There was a problem hiding this comment.
@meysam81 LGTM 👍
- I tested this: on the local devstack. Checked the existence of the issue in the master branch and then ensured this PR fixes it.
- I read through the code
- [N/A] I checked for accessibility issues
- Includes documentation
- [N/A] I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
@meysam81 can you check why CI is failing?
|
As far as I can tell the XSS linter is failing, which is related to templates and HTML. Is it possible for us to rebase this branch onto master and re-run the checks? |
d5574d8 to
d21b795
Compare
d21b795 to
6bf4364
Compare
|
@davidjoy I've rebased & squashed the changes. Seems like there is no failure anymore. |
|
@meysam81 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
Your PR has finished running tests. There were no failures. |
(cherry picked from commit 9726d14)
Description
So far, every RTL language style has been overwritten in every theme to cover for the unsupported behavior of RTL languages in the platform. This fix will address that and it'll reduce the overhead to do the same in the themes.
With this fix, we won't need to change any theme because the default will be to support the RTL languages even in the face of the default theme.
Reproducing
You'll need to run the
devstack, change the language to some RTL language (e.g.ar), and see the style correctly formatted in the default theme and any customized theme that hasn't patched the fix.Extra info
This PR is in regard to this ticket.
It also is a replacement for this PR.
reviewer @shimulch