Cherry-picks #28066 into koa.master - #28869
Conversation
fix!: Make default queue names service variant specific. (cherry picked from commit 4b29872)
|
Thanks for the pull request, @pomegranited! I've created OSPR-6081 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@pomegranited Thank you for the contribution. Will you find a reviewer among the CCs? |
Agrendalath
left a comment
There was a problem hiding this comment.
👍
- I tested this: verified that the celery check passes and the queues are set up correctly, checked that this cherry-picks #28066 (it has just one extra empty line removal)
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
|
@Agrendalath - for any PRs into any |
|
Second Internal review: @pomegranited All looks good 👍
|
... and @arbrandes I think is still the release manager for Koa. |
|
@edx-community-bot merge |
|
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Thank you for merging this @BbrSofiane ! |
Description
Cherry-picks https://github.com/edx/edx-platform/pull/28066 into
open-release/koa.master.Testing instructions
(Ocim Admins only)
Visit https://periodic-build-koa.opencraft.hosting/heartbeat?extended
Ensure that the
celerycheck is passing.Shell into the latest deployed instance and run:
Deadline
None
Review
CC @bradenmacdonald