Alex/multiple transcripts editor - #2899
Conversation
|
@polesye fixed: I think should be |
|
Fully covered: Diff LMS/CMS/XModule coverage: common/lib/xmodule/xmodule/video_module/transcripts_utils.py ( Result => 94% |
|
Wow, this is huge! How urgent is this? |
There was a problem hiding this comment.
I'm a bit confused as to why it defaults to uk on the double uploads below but is sticky with the existing zh here. I suppose my real question is whether the double upload tests should do something to ensure the selected language is uk or is it purely a matter of the order in the listing and is that order predictable and guaranteed?
There was a problem hiding this comment.
I'm a bit confused as to why it defaults to uk on the double uploads below but is sticky with the existing zh here. I suppose my real question is whether the double upload tests should do something to ensure the selected language is uk or is it purely a matter of the order in the listing and is that order predictable and guaranteed?
To make sure that after editing previously created video module and adding new translations will not change currently used translation.
As you can see in this test, we have created video module with chinese translation and then edit this module by adding new translation.
Logic is here
|
@dmitchell This PR seems to be huge, but really is not so. On python part, video module was split into smaller files for simpler code support, and so we have many additions, but the code is not so changed actually:
Urgency: I think it would be nice to merge it this week, so you have today and tomorrow for sure to review it, so we will have rest of week to address your comments))) |
|
@cahrens FYI: I extended File uploader to make it works with |
|
It would be nice if the error handling was better when you select a language for a transcript, but then never upload the transcript. Right now you get the error bar at the bottom and a "broken editor" when you hit Save. |
There was a problem hiding this comment.
This test would be easier to understand if it said it was replacing the transcript file, instead of uploading (in this case, you press the Replace button, correct)? If the implementation of the step is correct, perhaps you can map 2 different BDD descriptions to the same method?
There was a problem hiding this comment.
This test would be easier to understand if it said it was replacing the transcript file, instead of uploading (in this case, you press the Replace button, correct)? If the implementation of the step is correct, perhaps you can map 2 different BDD descriptions to the same method?
Done.
|
Given the large number of new Lettuce tests (which I whole-heartedly applaud), I'd recommend having @jzoldak code review the tests. |
There was a problem hiding this comment.
Why is the option disabled in this case? I thought this code was filtering to the values passed in.
There was a problem hiding this comment.
Why is the option disabled in this case? I thought this code was filtering to the values passed in.
I have renamed this function. We just disable previously selected options.
|
I have reviewed the JavaScript files and the things that impact the metadata editor. I don't have enough context to figure out what changed and what did not in the xmodule video Python code. I think that is better reviewed by other Blades folks. And I don't know anything about the LMS tests, so I am also not reviewing those changes. If there is someone who is familiar with those tests, please tag them to review. |
|
@jzoldak please also review this PR. |
|
@auraz - Just as a follow-on to the error message @Lyla-Fischer mentioned above. I can see how the red error text/bar Studio renders may not be possible to modify/adjust the text for in this PR. The text inside the upload modal that reads "We're sorry, there was an error" would be great to update to what Lyla suggested: " Sorry, there was an error parsing the subtitles that you uploaded. Please check the format and try again." |
|
@Lyla-Fischer There will be this same message for all kind of exceptions. It is fine? Otherwise solving this will require proxy exception text from Studio to uploader snippet. I think @polesye use existing Studio snippet which does not allow this. |
|
@Lyla-Fischer @marcotuts Ok, will change, thank you! |
|
Don't change it if it is going to be wrong in other aspects of the system... Is it possible to make it effect only this one upload? |
|
@Lyla-Fischer Sure! (What I mean, that this particular upload handler in video player can possibly show different specific kinds of exceptions during SRT uploading.) |
|
Okay. Thanks for the clarification. |
There was a problem hiding this comment.
I would suggest using the %cont-truncated mixin, eliminating the need for the text-overflow and overflow rules here. (see _mixins.scss, line 311).
There was a problem hiding this comment.
I would suggest using the %cont-truncated mixin, eliminating the need for the text-overflow and overflow rules here. (see _mixins.scss, line 311).
Fixed.
Done. |
|
@dmitchell , @cahrens , @marcotuts , @jzoldak , @valera-rozuvan all comments are addressed. Please continue review. |
|
👍 Good to merge! |
There was a problem hiding this comment.
this width rule should be 45%, and .metadata-video-translations .create-setting should have a width of 100% not 88%. This ensures the button is the same width as the other list input button styles.
There was a problem hiding this comment.
this width rule should be 45%, and .metadata-video-translations .create-setting should have a width of 100% not 88%. This ensures the button is the same width as the other list input button styles.
Done.
|
I just tested with the latest, and the only bit that caught my eye that I think would be worth adjusting is some of the CSS for the list block as a whole. This link shows the difference between the existing list setting styling and the new styling introduced in this PR. https://www.dropbox.com/s/3qjhgh5eibsgvgw/Screenshot%202014-03-27%2011.07.54.png It would be great to sync up the alignment and input field sizing to what we have for the Video Sources setting. Edit: In order to be more specific at the changes I'm suggesting: |
|
@marcotuts your comments are addressed. |
|
I haven't thoroughly reviewed this but don't want to hold it up. If others accept it, go ahead. |
|
@polesye Why is the code coverage so low (video_module, video_handlers, transcript_utils)? Is the report not accurate? https://jenkins.testeng.edx.org/job/edx-platform-report/3823/Diff_Coverage_Report/? |
|
@polesye - the changes are great thanks for addressing that. 👍 from an HTML,CSS perspective. |
|
@cahrens As @auraz mentioned previously an actual coverage for python part is about 94%. Video player module has tests which run in different runtimes: CMS, LMS, and xmodule. |
|
Thank you for the information. I haven't had a chance to check this out again and review, but if you feel that the files have had adequate reviews by others, go ahead and merge when you are ready. |
|
@polesye unfortunately I don't have enough time to review thoroughly today and I'll be out on Monday and Tuesday. Can you please make sure that all the new lettuce tests run reliably before merging in and also keep an eye out for failures after this gets merged in? thx. |
There was a problem hiding this comment.
Is it possible not to overwrite content here? This can help when debugging.
There was a problem hiding this comment.
Please clarify. Let's talk about this bit later.
|
👍 |
Fix donwload subs for non youtube videos and non-en language - continue. Add acceptance tests. Add detetion of assets on request. Updated docstring. Add fixes and acceptance tests. Fix acceptance tests. Update docsrtings and cleanup code, resful for language_id. Specify exception type in POST. Fix url in upload module. Improve exception handling. Remove 'en' and catching in editable_metadata. Move descriptor.get_context test to lms tests. Add query parameter to translation dispatch. Response to format parameter of translatin GET request. Fix Acceprance test: Metadata Editor. move handlers to proper scores. Split video player into smaller files. Add ugettext and fix typoes. Add changelog. Support for downloading non-ascii filenames. Change event binding. Add content-language to download requests. Reractor POST handler to not update self.transcripts.
|
Only single flaky test is failing (acid_xblock). I'm going to merge it, as this test is confirmed to be flaky (See conversation in testeng room today, at 19:22 GMT+2) |
Alex/multiple transcripts editor
9 participants
Create an upload modal for video transcript translations (BLD-751: https://edx-wiki.atlassian.net/browse/BLD-751).
@cahrens please review
@valera-rozuvan please review
@frrrances please review
@dmitchell please review.
@olmar please review python part