This fixes LMS-2387 by removing a resize call that prevented scrolling. - #2932
Conversation
There was a problem hiding this comment.
what does this line do? If there is more than one matlab problem on a page, will those pose issues?
There was a problem hiding this comment.
It gets the codemirror object. Previously, cm was available as a global variable.
Yeah, if there are more than one on the page, it'll be a problem. hmm...
|
The syntax highlighting is nice! Should also get a review by @auraz . |
|
@davestgermain resizing the textarea doesn't work |
|
It didn't work before, did it? Is it supposed to be resizable? |
|
I can't remember. But in that case, add resize: none; to the css |
|
@polesye please review |
There was a problem hiding this comment.
Please move this setup to the capa/display.coffee, like it was done for javascriptinput.
|
Good to merge when comments will be addressed. 👍 |
It also enables syntax highlighting for matlab input fields, which wasn't previously enabled.
|
@polesye I moved the CodeMirror setup to display.coffee, and did the same for the codeinput.html (python) code editor, because the function is identical there. |
This fixes LMS-2387 by removing a resize call that prevented scrolling.
4 participants
It also enables syntax highlighting for matlab input fields, which
wasn't previously enabled.
@adampalay