[BB-4951] Implement feature flag to disable students un-enrollment by 0x29a · Pull Request #29326 · openedx/openedx-platform

0x29a · 2021-11-15T22:34:13Z

Description

This PR Implements a feature flag DISABLE_UNENROLLMENT that is used to disable students un-enrollment for all courses. The Unenrollment option should be disabled when this feature is set to True

Supporting Information

BB-4951

Testing Instructions

Check out to this branch 0x29a/bb4951/disable_unenrollment in the edx-plaftorm repository on a lilac devstack
In the lms.yml file, add DISABLE_UNENROLLMENT: true to Features
Go to the LMS dashboard at http://localhost:18000/dashboard and click on the settings gear of a course
Confirm that there is no option to unenroll

openedx-webhooks · 2021-11-15T22:34:19Z

Thanks for the pull request, @0x29a! I've created OSPR-6225 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

edx-status-bot · 2021-11-15T23:11:23Z

Your PR has finished running tests. The following contexts failed:

jenkins/python

natabene · 2021-11-16T17:03:21Z

@0x29a Thank you for your contribution. Is this ready for our review?

natabene · 2022-01-21T14:42:40Z

@0x29a If you are still interested in pursuing this, can you please push a commit to kick the checks off?

0x29a · 2022-02-07T12:43:37Z

@natabene, sorry for the silence here, I was on vacation till today.

Yes, I'm still interested. Will update branch, fix the CI failure in the coming weeks and let you know once it's ready for an upstream review.

natabene · 2022-04-05T14:41:02Z

@0x29a Just checking if you are still interested in finalizing this.

Implements a feature flag DISABLE_UNENROLLMENT that is used to disable students un-enrollment for all courses. The Unenrollment option should be disabled when this feature is set to True.

0x29a · 2022-04-11T11:35:59Z

@natabene, sorry for the delay! This is updated, fixed and ready for your review.

schenedx

Looks good to me on the logic.

timmc-edx

Looks good! Thanks to Simon for the domain-specific review. :-)

forgot I had some questions

Co-authored-by: Tim McCormack <tmccormack@edx.org>

timmc-edx · 2022-04-22T13:22:54Z

Looks great, thank you!

openedx-webhooks · 2022-04-22T13:24:28Z

@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

edx-pipeline-bot · 2022-04-22T15:26:39Z

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

edx-pipeline-bot · 2022-04-22T16:42:21Z

EdX Release Notice: This PR has been deployed to the production environment.

…dx#29326) Implements a feature flag DISABLE_UNENROLLMENT that is used to disable students un-enrollment for all courses. The Unenrollment option should be disabled when this feature is set to True. ref: BB-4951 Co-authored-by: tinumide <tinuade@opencraft.com> Co-authored-by: Tim McCormack <tmccormack@edx.org> (cherry picked from commit da4a6d6)

Implements a feature flag DISABLE_UNENROLLMENT that is used to disable students un-enrollment for all courses. The Unenrollment option should be disabled when this feature is set to True. ref: BB-4951 Co-authored-by: tinumide <tinuade@opencraft.com> Co-authored-by: Tim McCormack <tmccormack@edx.org> (cherry picked from commit da4a6d6)

Implements a feature flag DISABLE_UNENROLLMENT that is used to disable students un-enrollment for all courses. The Unenrollment option should be disabled when this feature is set to True. ref: BB-4951 Co-authored-by: tinumide <tinuade@opencraft.com> Co-authored-by: Tim McCormack <tmccormack@edx.org>

…dx#29326) Implements a feature flag DISABLE_UNENROLLMENT that is used to disable students un-enrollment for all courses. The Unenrollment option should be disabled when this feature is set to True. ref: BB-4951 Co-authored-by: tinumide <tinuade@opencraft.com> Co-authored-by: Tim McCormack <tmccormack@edx.org> (cherry picked from commit da4a6d6)

openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Nov 15, 2021

0x29a force-pushed the 0x29a/bb4951/disable_unenrollment branch from 70b2c4a to f1c3e24 Compare November 15, 2021 22:51

natabene added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Feb 7, 2022

0x29a force-pushed the 0x29a/bb4951/disable_unenrollment branch from f1c3e24 to 678437c Compare April 11, 2022 10:27

feat: add DISABLE_UNENROLLMENT feature flag

44ccac1

Implements a feature flag DISABLE_UNENROLLMENT that is used to disable students un-enrollment for all courses. The Unenrollment option should be disabled when this feature is set to True.

0x29a force-pushed the 0x29a/bb4951/disable_unenrollment branch from 678437c to 44ccac1 Compare April 11, 2022 11:14

openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Apr 12, 2022

timmc-edx reviewed Apr 21, 2022

View reviewed changes

Comment thread cms/envs/common.py Outdated

timmc-edx reviewed Apr 21, 2022

View reviewed changes

Comment thread common/djangoapps/student/views/dashboard.py

schenedx approved these changes Apr 21, 2022

View reviewed changes

timmc-edx previously approved these changes Apr 21, 2022

View reviewed changes

openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed awaiting prioritization labels Apr 21, 2022

0x29a and others added 2 commits April 22, 2022 12:23

docs: remove 'toggle_target_removal_date' annotation

2d86fe6

Co-authored-by: Tim McCormack <tmccormack@edx.org>

fix: add missing global config override

cdeee9c

0x29a force-pushed the 0x29a/bb4951/disable_unenrollment branch from 7633c99 to cdeee9c Compare April 22, 2022 10:29

timmc-edx approved these changes Apr 22, 2022

View reviewed changes

timmc-edx merged commit da4a6d6 into openedx:master Apr 22, 2022

openedx-webhooks added merged and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Apr 22, 2022

0x29a deleted the 0x29a/bb4951/disable_unenrollment branch April 22, 2022 14:02

0x29a restored the 0x29a/bb4951/disable_unenrollment branch May 5, 2022 12:05

0x29a deleted the 0x29a/bb4951/disable_unenrollment branch May 5, 2022 12:05

0x29a mentioned this pull request May 5, 2022

[BACKPORT] feat: Implement feature flag to disable students un-enrollment (#29326) #30348

Merged

0x29a mentioned this pull request Sep 21, 2022

[BB-6692] Prepare opencraft-release/nutmeg.2 branch for edx-platform open-craft/openedx-platform#490

Merged

Uh oh!

Conversation

0x29a commented Nov 15, 2021

Description

Supporting Information

Testing Instructions

Uh oh!

openedx-webhooks commented Nov 15, 2021

Uh oh!

edx-status-bot commented Nov 15, 2021

Uh oh!

natabene commented Nov 16, 2021

Uh oh!

natabene commented Jan 21, 2022

Uh oh!

0x29a commented Feb 7, 2022

Uh oh!

natabene commented Apr 5, 2022

Uh oh!

0x29a commented Apr 11, 2022

Uh oh!

Uh oh!

Uh oh!

schenedx left a comment

Choose a reason for hiding this comment

Uh oh!

timmc-edx left a comment

Choose a reason for hiding this comment

Uh oh!

timmc-edx commented Apr 22, 2022

Uh oh!

openedx-webhooks commented Apr 22, 2022

Uh oh!

edx-pipeline-bot commented Apr 22, 2022

Uh oh!

edx-pipeline-bot commented Apr 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants