fix: course discovery dates localization after user logout - #29772
Conversation
|
Thanks for the pull request, @dyudyunov! I've created OSPR-6397 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
needs triage
open-source-contribution
9da1090 to
2eb4f08
Compare
|
@dyudyunov Thank you for your contribution. Is this ready for our review? |
Hi 👋 |
|
@dyudyunov could you rebase your commit on top of master so that checks run again? |
Sure ) |
Preconditions: - course discovery enabled STR: - log in - choose any language with different date format (e.g. ukrainian) - check date format changed on the /courses page - logout and go to /courses again AR: - date format is english on /courses, but stays the same as for logged in user on the main page ER: - date format stays the same as for logged in user
2eb4f08 to
2716810
Compare
|
Now that checks passed and given @natabene comments on the cc-channel I'm merging now. |
|
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
…gout Preconditions: - course discovery enabled STR: - log in - choose any language with a different date format (e.g. Ukrainian) - check date format changed on the /courses page - logout and go to /courses again AR: - date format is English on /courses, but stays the same as for logged in user on the main page ER: - date format stays the same as for logged in user Related PR to the master branch: - #29772
7 participants
Preconditions:
STR:
AR:
user on the main page
ER:
Related PR to the open-release/maple.master branch: