Skip to content

feat!: remove all access to Old Mongo courses - #30172

Merged
mikix merged 1 commit into
masterfrom
mikix/remove-old-mongo-access2
Apr 4, 2022
Merged

feat!: remove all access to Old Mongo courses#30172
mikix merged 1 commit into
masterfrom
mikix/remove-old-mongo-access2

Conversation

@mikix

@mikix mikix commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

Change has_access to deny 'load' support for Old Mongo courses.

This is in service of dropping support for these ancient courses and removing legacy code that they rely on.

DEPR-58
DEPR-123

Here's a screenshot of what the dashboard looks like after this change. You can see both the error message we show when you try to go to an Old Mongo course (you get redirected to dashboard with this mesage). And you can see how an Old Mongo course card shows up - it's still there, but without any links.
Screenshot from 2022-02-17 11-13-15

This previously landed in #29848 but got reverted because it accidentally broke some tests.

Change has_access to deny 'load' support for Old Mongo courses.

This is in service of dropping support for these ancient
courses and removing legacy code that they rely on.

DEPR-58
@mikix

mikix commented Apr 4, 2022

Copy link
Copy Markdown
Contributor Author

Hmm, the same test failure didn't show up. And I can't reproduce locally either. It might have just been a flaky test and I over-reacted?

I will try landing again.

@mikix
mikix merged commit 3abd1c5 into master Apr 4, 2022
@mikix
mikix deleted the mikix/remove-old-mongo-access2 branch April 4, 2022 14:59
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

ormsbee pushed a commit that referenced this pull request Oct 12, 2022
LMS Courseware access to Old Mongo courses was already removed in
fc8601d (#30172). This
commit makes direct links to the other tabs (progress, instructor
dashboard, discussion, static tabs) fail with a 404 error on Old
Mongo courses.

Upcoming work to remove parent/child relationships from the Old
Mongo Modulestore would have broken these pages anyway.
awais786 pushed a commit that referenced this pull request Jan 13, 2023
LMS Courseware access to Old Mongo courses was already removed in
fc8601d (#30172). This
commit makes direct links to the other tabs (progress, instructor
dashboard, discussion, static tabs) fail with a 404 error on Old
Mongo courses.

Upcoming work to remove parent/child relationships from the Old
Mongo Modulestore would have broken these pages anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants