Skip to content

[BACKPORT] fixup! feat: options for excluding courses from search (#28518) - #30373

Merged
mtyaka merged 1 commit into
openedx:open-release/maple.masterfrom
open-craft:pooja/se-4682-maple-backport
Jun 30, 2022
Merged

[BACKPORT] fixup! feat: options for excluding courses from search (#28518)#30373
mtyaka merged 1 commit into
openedx:open-release/maple.masterfrom
open-craft:pooja/se-4682-maple-backport

Conversation

@pkulkark

Copy link
Copy Markdown
Contributor

This is a backport of #28518

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 12, 2022
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @pkulkark! I've created OSPR-6673 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@pkulkark
pkulkark force-pushed the pooja/se-4682-maple-backport branch from afdb9cf to abe5c63 Compare May 16, 2022 06:53
@natabene

Copy link
Copy Markdown
Contributor

@pkulkark Thank you for your contribution. @BbrSofiane Can you please review and merge?

@mtyaka mtyaka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this backport 👍

  • I tested this: I tested that when using the two flags I can successfully remove invitation only and/or courses with catalog visibility set to "none" from the course discovery/search page.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@mtyaka
mtyaka merged commit 110dfac into openedx:open-release/maple.master Jun 30, 2022
@openedx-webhooks

Copy link
Copy Markdown

@pkulkark 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Agrendalath
Agrendalath deleted the pooja/se-4682-maple-backport branch July 1, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants