Skip to content

Clarify a potentially confusing deprecation message [MNG-3057] - #30535

Merged
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:mako-rendering-deprecation
Jun 29, 2022
Merged

Clarify a potentially confusing deprecation message [MNG-3057]#30535
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:mako-rendering-deprecation

Conversation

@bradenmacdonald

Copy link
Copy Markdown
Contributor

Description

I just noticed that a certain deprecation warning hasn't been updated to mention the mako service which was introduced in #29354 , so this updates the text. I'm not sure if/when anyone is going to see this though if all the existing blocks have been converted to the new service already.

Supporting information

Testing instructions

Not really necessary.

Deadline

None

Other information

Suggested reviewer: @pomegranited

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jun 2, 2022
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald! I've created OSPR-6753 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bradenmacdonald
bradenmacdonald force-pushed the mako-rendering-deprecation branch from 393621a to f9c9ef1 Compare June 2, 2022 21:17
@natabene

natabene commented Jun 6, 2022

Copy link
Copy Markdown
Contributor

@bradenmacdonald Thank you for your contribution. Is this ready for our review?

@bradenmacdonald

Copy link
Copy Markdown
Contributor Author

@natabene Yes, thanks. I think @pomegranited would be a good reviewer.

@natabene

natabene commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

@pomegranited Would you like to review?

@pomegranited

Copy link
Copy Markdown
Contributor

Hi @natabene , yep, I can review! I've scheduled this for next week.

@natabene natabene assigned natabene and pomegranited and unassigned natabene Jun 7, 2022

@pomegranited pomegranited left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this issue @bradenmacdonald ! We converted the XBlocks in edx-platform to use the mako service's render_template method instead, but there's surely XBlocks outside the platform which still use it. So this is worth updating :)

👍

  • I tested this N/A -- string change only
  • I read through the code
  • I checked for accessibility issues N/A
  • Updates documentation

@bradenmacdonald
bradenmacdonald merged commit 5d93f88 into openedx:master Jun 29, 2022
@bradenmacdonald
bradenmacdonald deleted the mako-rendering-deprecation branch June 29, 2022 19:13
@openedx-webhooks

Copy link
Copy Markdown

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants