Skip to content

refactor: [BB-6077] allow setting celery backend in yml - #30572

Merged
github-actions[bot] merged 1 commit into
openedx:open-release/nutmeg.masterfrom
open-craft:navin/fix-celery-backend-nutmeg
Aug 2, 2022
Merged

refactor: [BB-6077] allow setting celery backend in yml#30572
github-actions[bot] merged 1 commit into
openedx:open-release/nutmeg.masterfrom
open-craft:navin/fix-celery-backend-nutmeg

Conversation

@navinkarkera

@navinkarkera navinkarkera commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

Description

Cherry pick of #30244

At Opencraft, we want to run multiple instances of celery workers in separate servers. The celery workers need to be able to share task results. Currently, the CELERY_RESULT_BACKEND is hard coded to use django-cache.

So this PR allows to setup CELERY_RESULT_BACKEND via configuration.

To use django ORM as celery backend, one can set CELERY_RESULT_BACKEND to django-db as described in docs.

Supporting information

Deadline

"None"

@openedx-webhooks

openedx-webhooks commented Jun 13, 2022 •
edited
Loading

Copy link
Copy Markdown

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jun 13, 2022
@natabene

natabene commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

@navinkarkera Thank you for your contribution. Is this ready for our review?

@navinkarkera
navinkarkera force-pushed the navin/fix-celery-backend-nutmeg branch from 1491391 to 26433f7 Compare June 16, 2022 04:33
@navinkarkera

navinkarkera commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

@natabene Thank you! Yes it s ready for your review.
cc: @kaustavb12

kaustavb12
kaustavb12 approved these changes Jun 16, 2022
View reviewed changes

@kaustavb12 kaustavb12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good to me

  • I tested this: Tested in the PR sandbox
  • I read through the code

@BbrSofiane

BbrSofiane commented Jul 3, 2022

Copy link
Copy Markdown
Contributor

@navinkarkera sorry for the delay in looking at this PR. Can you please have a look at the failing tests?

@navinkarkera
navinkarkera force-pushed the navin/fix-celery-backend-nutmeg branch from 26433f7 to b2c5b24 Compare July 6, 2022 04:56
@navinkarkera

navinkarkera commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

@BbrSofiane Rebase fixed it. Please have a look.

@navinkarkera
navinkarkera force-pushed the navin/fix-celery-backend-nutmeg branch from b2c5b24 to 41b18d0 Compare July 14, 2022 04:05
@natabene

natabene commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

@BbrSofiane This is ready for your review again.

@OmarIthawi OmarIthawi mentioned this pull request Jul 27, 2022
Merged
@BbrSofiane

BbrSofiane commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

@openedx/edx-community-bot merge

@BbrSofiane

BbrSofiane commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

@edx-community-bot merge

@BbrSofiane

BbrSofiane commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

@jfavellar90 can you merge this PR?

@Carlos-Muniz

Carlos-Muniz commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

@BbrSofiane The command to auto-merge is: @openedx-community-bot merge
Please see openedx/axim-engineering#299 (comment) for more detail

@jfavellar90

jfavellar90 commented Aug 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@openedx/edx-community-bot merge

@mariajgrimaldi

mariajgrimaldi commented Aug 2, 2022

Copy link
Copy Markdown
Member

could it possibly be a permissions issue? I could merge it :)

@Carlos-Muniz

Carlos-Muniz commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

@jfavellar90 @mariajgrimaldi
Yes the @openedx-community-bot merge command only works for a couple of users, like @BbrSofiane.

@BbrSofiane

BbrSofiane commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

@openedx-community-bot merge

@BbrSofiane

BbrSofiane commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

Thanks I always look for the actual bot

@github-actions
github-actions Bot merged commit 294c1f3 into openedx:open-release/nutmeg.master Aug 2, 2022
@openedx-webhooks

openedx-webhooks commented Aug 2, 2022

Copy link
Copy Markdown

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@0x29a 0x29a mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@OmarIthawi OmarIthawi OmarIthawi approved these changes
@BbrSofiane BbrSofiane BbrSofiane approved these changes
@jfavellar90 jfavellar90 jfavellar90 approved these changes
@kaustavb12 kaustavb12 kaustavb12 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BbrSofiane BbrSofiane

Labels

automerge open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@navinkarkera @openedx-webhooks @natabene @BbrSofiane @Carlos-Muniz @jfavellar90 @mariajgrimaldi @OmarIthawi @kaustavb12