Skip to content

Revert to older version of TinyMCE. - #3067

Merged
cahrens merged 1 commit into
rc/2014-03-24from
christina/revert_tinymce
Mar 26, 2014
Merged

Revert to older version of TinyMCE.#3067
cahrens merged 1 commit into
rc/2014-03-24from
christina/revert_tinymce

Conversation

@cahrens

@cahrens cahrens commented Mar 26, 2014

Copy link
Copy Markdown

We had issues related to Cloudfront and file hashing. More time is needed for investigation.

@rocha Here is the revert of the TinyMCE version.

@andy-armstrong Do you want to code review? It's not an easy thing to review, though perhaps you could check out the branch and do some quick manual testing with the HTML component (not that I haven't already done that...).

@frrrances Also tagging you as an interested party.

This PR reverts #2657.

We had trouble with Cloudfront/hashed files and need more time
to investigate.
This reverts commit e8f53ac9dc6d8a1d9928787635c7c5f7e409a9ec.
@andy-armstrong

Copy link
Copy Markdown
Contributor

👍 I skimmed the code and everything I was expecting to see reverted is back. I also tested the branch and the sad old UI seems to be working fine.

Comment thread CHANGELOG.rst

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @mhoeber we are rolling back this feature.

@rocha

rocha commented Mar 26, 2014

Copy link
Copy Markdown
Contributor

LGTM 🚀

@frrrances

Copy link
Copy Markdown
Contributor

😢 👍

cahrens pushed a commit that referenced this pull request Mar 26, 2014
Revert to older version of TinyMCE.
@cahrens
cahrens merged commit e394a19 into rc/2014-03-24 Mar 26, 2014
@ovnicraft

Copy link
Copy Markdown
Contributor

:'( @cahrens any conversation in edx-code to know more about your issue ?

@jzoldak
jzoldak deleted the christina/revert_tinymce branch May 5, 2014 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants