[BB-6438] Check if feature is enabled before calling enterprise api - #30693
Conversation
This fixes the issue of django messages being read before redirecting to dashboard page, due to enterprise api being called even if the feature is disabled.
|
Thanks for the pull request, @pkulkark! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
navinkarkera
left a comment
There was a problem hiding this comment.
👍
- I tested this on sandbox
- I read through the code
- I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
|
@natabene This is good for edX's review. |
|
@pkulkark Thank you for your contribution! |
|
@pkulkark I have lined this up for our review. |
|
@pkulkark 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description
This PR fixes the issue of django messages being read before redirecting to dashboard page, due to enterprise api being
called even if the feature is disabled. Before maple release, there used to be a waffle switch named
ENABLE_MULTIPLE_USER_ENTERPRISES_FEATUREthat was checked before calling the api. This was deprecated in edx-platform#28057 but was not replaced by any other check for enterprise integration. And so after each login, the enterprise api would be called, which would return 404 but was fetching the django messages (which clears it) and so page banner messages wouldn't show up when the user was redirected to the dashboard page.Supporting information
JIRA: BB-6438
Testing instructions
lms.ymlandstudio.ymlfiles, underAUTH_PASSWORD_VALIDATORSupdate the minimum password length requirement to longer than the one you set in the previous step.Reviewers
TBD