fix: Update to the new error messages and some fixes - #30826
Conversation
99270d5 to
56f881a
Compare
waheedahmed
left a comment
waheedahmed
left a comment
There was a problem hiding this comment.
Couple of questions otherwise looks good.
There was a problem hiding this comment.
I guess we don't need to remove the dot for the first sentence of this message. Or maybe needed to convert it into a comma, can you please confirm?
Our system detected that your password is vulnerable, we recommend you change it so that your account stays secure
There was a problem hiding this comment.
Same here, do we need to convert the dot into a comma for the first sentence, it looks odd if we remove the dot at the end of the message but not in the middle. Please confirm with UX.
Our system detected that your password is vulnerable, change your password so that your account stays secure
There was a problem hiding this comment.
@waheedahmed Okay i will confirm it from UX and update it according to their suggestion
56f881a to
1f2da75
Compare
|
@waheedahmed I have updated the PR according to UX review. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been deployed to the production environment. |
3 participants
Description
Update the error message both backend and frontend to make it consistent and also makes some fixes.
VAN-976