build: Clear out stale dependencies when installing requirements

.github/workflows/js-tests.yml

@@ -63,7 +63,6 @@ jobs:
 
     - name: Install Required Python Dependencies
       run: |
-        pip install -r requirements/pip.txt
         make base-requirements
 
     - uses: c-hive/gha-npm-cache@v1

.github/workflows/migrations-check-mysql8.yml

@@ -50,7 +50,6 @@ jobs:
 
     - name: Install Python dependencies
       run: |
-        pip install -r requirements/pip.txt
         make dev-requirements
         pip uninstall -y mysqlclient
         pip install --no-binary mysqlclient mysqlclient

.github/workflows/migrations-check.yml

@@ -60,7 +60,6 @@ jobs:
 
     - name: Install Python dependencies
       run: |
-        pip install -r requirements/pip.txt
         make dev-requirements
         pip uninstall -y mysqlclient
         pip install --no-binary mysqlclient mysqlclient

.github/workflows/pylint-checks.yml

@@ -57,7 +57,6 @@ jobs:
 
       - name: Install required Python dependencies
         run: |
-          pip install -r requirements/pip.txt
           make dev-requirements
           pip uninstall -y mysqlclient
           pip install --no-binary mysqlclient mysqlclient

.github/workflows/static-assets-check.yml

@@ -49,7 +49,6 @@ jobs:
 
     - name: Install Required Python Dependencies
       run: |
-        pip install -r requirements/pip.txt
         make base-requirements
 
     - name: Initiate Mongo DB Service

.github/workflows/unit-tests.yml

@@ -61,7 +61,6 @@ jobs:
 
       - name: install requirements
         run: |
-          sudo pip install -r requirements/pip.txt
           sudo make test-requirements
           if [[ "${{ matrix.django-version }}" == "pinned" ]]; then
             sudo pip install -r requirements/edx/django.txt

.github/workflows/verify-gha-unit-tests-count.yml

@@ -17,7 +17,6 @@ jobs:
       - uses: actions/checkout@v2
       - name: install requirements
         run: |
-          sudo pip install -r requirements/pip.txt
           sudo make test-requirements
 
       - name: verify unit tests count

Makefile

@@ -64,26 +64,28 @@ pull: ## update the Docker image used by "make shell"
 	docker pull edxops/edxapp:latest
 
 pre-requirements: ## install Python requirements for running pip-tools
+	pip install -qr requirements/pip.txt
 	pip install -qr requirements/edx/pip-tools.txt
 
 local-requirements:
 # 	edx-platform installs some Python projects from within the edx-platform repo itself.
 	pip install -e .
 
-dev-requirements: local-requirements
-	pip install -qr requirements/edx/development.txt
-
-base-requirements: local-requirements
-	pip install -qr requirements/edx/base.txt
-
-test-requirements: local-requirements
-	pip install --exists-action='w' -qr requirements/edx/testing.txt
-
-requirements: pre-requirements ## install development environment requirements
+dev-requirements: pre-requirements
 	@# The "$(wildcard..)" is to include private.txt if it exists, and make no mention
 	@# of it if it does not.  Shell wildcarding can't do that with default options.
 	pip-sync -q requirements/edx/development.txt $(wildcard requirements/edx/private.txt)
-	pip install -e .
+	make local-requirements
+
+base-requirements: pre-requirements
+	pip-sync requirements/edx/base.txt
+	make local-requirements
+
+test-requirements: pre-requirements
+	pip-sync --pip-args="--exists-action=w" requirements/edx/testing.txt
+	make local-requirements
+
+requirements: dev-requirements ## install development environment requirements
 
 shell: ## launch a bash shell in a Docker container with all edx-platform dependencies installed
 	docker run -it -e "NO_PYTHON_UNINSTALL=1" -e "PIP_INDEX_URL=https://pypi.python.org/simple" -e TERM \
@@ -130,7 +132,7 @@ compile-requirements: $(COMMON_CONSTRAINTS_TXT) ## Re-compile *.in requirements
 		pip-compile -v --no-emit-trusted-host --no-emit-index-url $$REBUILD ${COMPILE_OPTS} -o $$f.txt $$f.in || exit 1; \
 		export REBUILD=''; \
 	done
- 	# Let tox control the Django version for tests
+	# Let tox control the Django version for tests
 	grep -e "^django==" requirements/edx/base.txt > requirements/edx/django.txt
 	sed '/^[dD]jango==/d' requirements/edx/testing.txt > requirements/edx/testing.tmp
 	mv requirements/edx/testing.tmp requirements/edx/testing.txt