[OldMongo FC-0004] Remove inheritance-related code from Old Mongo - #31099
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
919e838 to
643d241
Compare
|
@jristau1984: this will not merge until Monday at the earliest (2022-10-17). |
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
Code changes look good. Minor points:
- Can we get rid of some of this performance testing code rather than adjusting the numbers upward?
- Removal of features should have a
feat!:conventional commit syntax.
FYI @jristau1984: If there is an unexpected use of Old Mongo for course content, you may see increased MongoDB load in New Relic after this PR merges, because it removes part of Old Mongo's internal caching layer. I don't really expect this to happen, and if it does happen, I think that the relatively small number of Old Mongo courses means that it won't threaten site stability. But it might be a useful canary test before the next set of removals.
@jmbowman: There is a chance that this PR merge will temporarily make the test suite slower (until #31134 merges after it).
| (3, 17, 15, 16, 12), | ||
| (1, 25, 23, 26, 20), | ||
| (2, 51, 49, 52, 46), | ||
| (3, 141, 139, 142, 136), |
There was a problem hiding this comment.
Are these numbers higher because this test is running against Old Mongo instead of Split? If so, can we convert it to split? And if it's purely testing Old Mongo performance (i.e. not correctness), can we get rid of it altogether rather than running it more slowly?
| (3, 34), | ||
| (1, 52), | ||
| (2, 82), | ||
| (3, 176), |
There was a problem hiding this comment.
Same question as above about whether this can be converted to Split or removed altogether.
There was a problem hiding this comment.
Yes, this changes will be converted to Split in #31134. I leaved this test with Old Mongo modulestore for checking. Should I convert to split in this PR?
There was a problem hiding this comment.
Yes, we can get rid of them.
- If there are tests that never worked for Split Mongo, we should get rid of them.
- If there are tests that specifically test Old Mongo performance, we should probably get rid of them.
- If there are tests that exercise Old Mongo functionality that we intend to remove, we can get rid of them now, or save them for another PR where removing them is more natural.
There was a problem hiding this comment.
The tests have been updated, the rest of the tests will be in the next PR
643d241 to
230633f
Compare
|
@ormsbee commit message updated with |
230633f to
3575b3b
Compare
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
@jristau1984: As a heads up, I plan to merge this Old Mongo PR on Monday morning.
|
@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
4 participants
Description
Useful information to include:
openedx/public-engineering#79