Skip to content

[WIP][BD-13][BB-6732] refactor: Remove unused XModule classes - #31110

Closed
0x29a wants to merge 1 commit into
openedx:masterfrom
open-craft:0x29a/bb6732/remove_unused_xmodule_classes
Closed

[WIP][BD-13][BB-6732] refactor: Remove unused XModule classes#31110
0x29a wants to merge 1 commit into
openedx:masterfrom
open-craft:0x29a/bb6732/remove_unused_xmodule_classes

Conversation

@0x29a

@0x29a 0x29a commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @0x29a!

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Oct 5, 2022
@Cup0fCoffee

Copy link
Copy Markdown
Contributor

@0x29a Can you please close this PR in favor of #31173?

@0x29a 0x29a closed this Oct 19, 2022
@openedx-webhooks

Copy link
Copy Markdown

@0x29a Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@0x29a
0x29a deleted the 0x29a/bb6732/remove_unused_xmodule_classes branch October 19, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants