test: update exams tests to use split modulestore - #31223
Merged
Conversation
zacharis278
force-pushed
the
zhancock/modulestore-testfix
branch
from
October 27, 2022 20:48
9fbf192 to
ec5dd86
Compare
schenedx
approved these changes
Oct 28, 2022
schenedx
left a comment
schenedx
left a comment
Contributor
There was a problem hiding this comment.
As long as the python unit tests are happy, I am happy. Thank you for the fix!
ashultz0
approved these changes
Oct 28, 2022
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
jcohen28
pushed a commit
to Medality-Health/edx-platform
that referenced
this pull request
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #31134
These tests are currently using the old modulestore but when updated to the correct modulestore value you end up with a bunch of inexplicable test failures. Why? TIL
is_proctored_examis not actually a field on these blocks and is actually an alias tois_proctored_enabledso creating sections with is_proctored_exam does nothing.https://github.com/openedx/edx-platform/blob/9fbf1929dddcdfdfebd9a1e48a490a7f84b6e536/xmodule/seq_module.py#L226
Seems like old mongo would save this value anyway but split modulestore does not.