[OldMongo FC-0004] Tests for removing support for children in Old Mongo - part 3 - #31466
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
3da99b8 to
d2418de
Compare
* updated test_authoring_mixin.py * updated test_xblock_utils.py * updated TestOnboardingView tests (update default course key) * updated UsersDefaultRole tests
d2418de to
a80eb48
Compare
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
One sanity-checking question, but otherwise looks good.
| DRAFT_VIDEO = 'draft_video' | ||
| LOCKED_ASSET_KEY = AssetKey.from_string('/c4x/edX/toy/asset/sample_static.html') | ||
|
|
||
| def import_and_populate_course(self): |
There was a problem hiding this comment.
Just as a sanity check: It's okay to remove this because there's already an equivalent testing split mongo specifically, right?
There was a problem hiding this comment.
Yes we have similar test for split mongo, so I think we can remove this test.
(xmodule/modulestore/tests/test_cross_modulestore_import_export.py::CrossStoreXMLRoundtrip)
|
@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
4 participants
Description
Should be merged after: #31427
Third part of preparing tests for
Remove support for children in Old Mongotask (#31134).Useful information to include:
First part: #31422
Second part: #31427
Remove support for children in Old Mongo PR: #31134
openedx/public-engineering#80