fix: add missing variables to library_listing context - #31752
Conversation
|
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
connorhaugh
left a comment
There was a problem hiding this comment.
Looks good to me. For those playing along at home, the testing instructions are:
- Enable the waffle flag contentstore.split_library_on_studio_dashboard.
- Go to the CMS and open select Libraries or go directly to the view /home_library.
- See the library listing page.
- Disable the waffle flag
- /home http://localhost:18010/home#libraries-tab still works.
|
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Thank you so much @Ian2012 ! |
|
@connorhaugh glad to help! |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description
This PR fixes an internal error raised when the waffle flag
contentstore.split_library_on_studio_dashboardis enabled and users access to the/home_libraryview. It failed because the library view doesn't have in the context, the variables introduced in the PR that added the dropdown functionality #30975Supporting information
The PR that added the dropdown functionality is this one #30975
Testing instructions
contentstore.split_library_on_studio_dashboard./home_library.