Skip to content

fix: add missing variables to library_listing context - #31752

Merged
connorhaugh merged 2 commits into
openedx:masterfrom
eduNEXT:cag/fix-course-creator-dropdown-with-split-library
Feb 13, 2023
Merged

fix: add missing variables to library_listing context#31752
connorhaugh merged 2 commits into
openedx:masterfrom
eduNEXT:cag/fix-course-creator-dropdown-with-split-library

Conversation

@Ian2012

@Ian2012 Ian2012 commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

Description

This PR fixes an internal error raised when the waffle flag contentstore.split_library_on_studio_dashboard is enabled and users access to the /home_library view. It failed because the library view doesn't have in the context, the variables introduced in the PR that added the dropdown functionality #30975

Supporting information

The PR that added the dropdown functionality is this one #30975

Testing instructions

  1. Enable the waffle flag contentstore.split_library_on_studio_dashboard .
  2. Go to the CMS and open select Libraries or go directly to the view /home_library .
  3. See the error.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 13, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@connorhaugh connorhaugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. For those playing along at home, the testing instructions are:

  1. Enable the waffle flag contentstore.split_library_on_studio_dashboard.
  2. Go to the CMS and open select Libraries or go directly to the view /home_library.
  3. See the library listing page.
  4. Disable the waffle flag
  5. /home http://localhost:18010/home#libraries-tab still works.

@connorhaugh
connorhaugh merged commit 4ed8dde into openedx:master Feb 13, 2023
@openedx-webhooks

Copy link
Copy Markdown

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@connorhaugh

Copy link
Copy Markdown
Contributor

Thank you so much @Ian2012 !

@Ian2012

Ian2012 commented Feb 13, 2023

Copy link
Copy Markdown
Contributor Author

@connorhaugh glad to help!

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants