Revert "feat: unify ModuleSystem and DescriptorSystem [BD-13]" - #32118
Closed
Agrendalath wants to merge 1 commit into
Closed
Revert "feat: unify ModuleSystem and DescriptorSystem [BD-13]"#32118Agrendalath wants to merge 1 commit into
Agrendalath wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @Agrendalath! This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
Member
Author
|
Looks like it's working well so far. Closing. |
|
@Agrendalath Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Agrendalath
deleted the
revert-31472-kaustav/unify_modulesystem_descriptorsystem
branch
April 25, 2023 14:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #31472.
Opening it just in case...