Decouple XModule styles from LMS/Studio styles (attempt 2) - #32188
Conversation
This basically changes how the xmodule static files are generated and consumed in order to separate the Xblock styles from general style files. Addressing the issue openedx#31624
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @andrey-canon! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
Hi @kdmccormick, could you please review it ?, this fixes the theme dependencies issue |
kdmccormick
left a comment
kdmccormick
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. I confirmed this with the red-theme, dark-theme, and tutor-indigo theme.
|
@andrey-canon 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
kdmccormick
changed the title
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
Reverted by #32191 |
This basically changes how the xmodule static files are generated and consumed in order to separate the Xblock styles from general style files. Includes: * build: decople XModule style assets by using a custom webpack loader * build: move scss imports to its specific file * build: fix: add system dirs to theme lookup paths. (fixes attempt 1) * build: fix: use bootstrap variables instead of lms variables (fixes attempt 2) This is an amendment to #32188, which itself was an amendment to #32018. Addressing the issue #31624
4 participants
Description
This pr includes the changes of this #32018 and fixes compilation issue, which was described in this revert #32183
The fix 19d4971
Testing instructions
For basic testing please go to #32018 and follow the steps described there
For theme testing (Using tutor)
/end/build/openedx/themestutor dev start[--mount=./some path if you want to set a edx-platform volume] and waitdocker exec -it tutor_nightly_dev-lms-1 /bin/bashopenedx-assets themes --theme-dirs /openedx/themes /openedx/themes/parent-folder-of -your-theme --themes name-of-your-themeResults
Previous the fix
After the fix